From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH] Date: Wed, 07 Nov 2018 11:53:23 +0300 Message-ID: References: <8237cee2-9e65-4093-8077-a458cf58c911@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541580735 28548 195.159.176.226 (7 Nov 2018 08:52:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2018 08:52:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Cc: Alan Third , 33154@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 07 09:52:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKJZJ-0007Gj-Cn for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Nov 2018 09:52:10 +0100 Original-Received: from localhost ([::1]:46471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKJbP-0001ce-PE for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Nov 2018 03:54:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKJbG-0001cN-A0 for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 03:54:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKJb8-0001L4-3C for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 03:54:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKJb7-0001KX-Rh for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 03:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKJb7-00031j-Ji for bug-gnu-emacs@gnu.org; Wed, 07 Nov 2018 03:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Nov 2018 08:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33154-submit@debbugs.gnu.org id=B33154.154158081511599 (code B ref 33154); Wed, 07 Nov 2018 08:54:01 +0000 Original-Received: (at 33154) by debbugs.gnu.org; 7 Nov 2018 08:53:35 +0000 Original-Received: from localhost ([127.0.0.1]:38103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKJag-000311-QL for submit@debbugs.gnu.org; Wed, 07 Nov 2018 03:53:34 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKJae-00030o-Na for 33154@debbugs.gnu.org; Wed, 07 Nov 2018 03:53:33 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 030BF221BF; Wed, 7 Nov 2018 03:53:27 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 07 Nov 2018 03:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=jpbBEPBwaUT+mychMWuJN7lZ2g T8fLXwv1pj+YAGs3Q=; b=U4tF4ie3bIUqz0mxpZ1UK1IDl+GSMLT19ZAyCKmDu0 buqcMwDlA91bJH9rhKNKaOlXssMqQl0eLL39fekT+wKe+Pgpn3xvet09boRblASG QbMtUNOy4R1y7wU+lYREAA8Gp1k979kJr+H9kO7WQJFnNllHCdainz0fxDwoFyHV y/uSxV+mWmVOUSFePG4J4wq1SRtwxbhFY8DgR8YEq9F8pxFYor4BdTFTu/wG2yMe 3v20qrgyXTOxwQkNRArgqaZ07kZwPHCEi+TLIa79zj3voV9GqYfi/XH1teGz6nLJ yWH5A5txIe/DlDhKox4/Q3N4xhu0sNE1wOlJ8wCFsbhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jpbBEP BwaUT+mychMWuJN7lZ2gT8fLXwv1pj+YAGs3Q=; b=Q2iYCFLx06kUymw2Zd1jfW exmD0n20Tj/cj1X++IZKfm+c5Ww+QjoSRhQsBb1IQScf/SryiHTXJTsTUhbQXUjt 2v7hhj07fevs+tHQU9jcLIPo3h6c3sge6CYV8tRV0cmrwr+09oOlpjQThDX6NfU9 SxAQIEcSlZpuma87/PFRxA4nGdW2gZ4xmPxkNat/nv5cehYDisBFP4mFyF7pWlKH SqVidjDxNWGt18/Rs0bJQ/mTHpR/Q4O+00pwO5AFvpxD1kqbCxI7sk1BUgvVtnWl O9fU30RpN8mAqh7rcROI+0Uc85XoMP0pcdCLrQibVe8wUWkbavWkRoxuJqmwx1UQ == X-ME-Sender: X-ME-Proxy: Original-Received: from fgunbin.local (unknown [93.185.27.48]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CB80102DE; Wed, 7 Nov 2018 03:53:25 -0500 (EST) In-Reply-To: (Paul Eggert's message of "Tue, 6 Nov 2018 23:41:46 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152121 Archived-At: Yes, dissociate_controlling_tty looks nice. I thought about checking what setsid() returns too, but thought I'd do this after some testing. > Also, I think we can call the function from just two places (not > three). Are you sure we can remove that 3rd place? It dates back to initial revision from 1992. And I can't tell why it's there and what it does. Filipp