From: Sebastian Tennant <sebyte@smolny.plus.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#2103: Bug in simple.el
Date: Thu, 29 Jan 2009 07:06:22 +0000 [thread overview]
Message-ID: <ljsu8uc1.fsf@vps203.linuxvps.org> (raw)
In-Reply-To: jwveiyno719.fsf-monnier+emacs@gnu.org
Hi Stefan,
Returning to the bug list, in case others have opinions on the matter...
Quoth Stefan Monnier <monnier@iro.umontreal.ca>:
>> Apologies for contacting you off-list. I'm doing so just in case you'd
>> given up on me. My penultimate email to the Emacs bug list was
>> something of a rant!
>>
>> Since then I think I've found the perfect solution. A hook needs to be
>> added to simple.el providing ^M handling and we don't need to change
>> anything in shell-command.
>>
>> http://article.gmane.org/gmane.emacs.help/61630
>
> Hooks are great for users, but for internal use they're usually
> better avoided since we can change the code directly instead.
But in this case, some users may not want ^M handling, so providing a
hook gives users the choice, no?
> E.g. in this case we want to change shell-command.
I agree that given the command is called 'shell-command' it would make
sense for ^M characters to be handled in shell-like way, i.e., no ^Ms,
in which case perhaps we should provide a spearate command for users who
_don't_ want ^M handling; 'unfiltered-shell-command' or something like
that?
Then again, adding a hook and leaving shell-command as it stands is the
simplest option and has the advantage of not breaking anything, i.e.,
no backward compatibility issues.
Seb
next parent reply other threads:[~2009-01-29 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <63k0dk26.fsf@vps203.linuxvps.org>
[not found] ` <jwveiyno719.fsf-monnier+emacs@gnu.org>
2009-01-29 7:06 ` Sebastian Tennant [this message]
2009-08-11 4:45 ` bug#2103: marked as done (Bug in simple.el) Emacs bug Tracking System
[not found] <87ocqnneu3.fsf@cyd.mit.edu>
2009-01-20 20:10 ` bug#1973: Bug in simple.el (Emacs version 22.2.1) Sebastian Tennant
2009-01-21 4:59 ` Kevin Rodgers
2009-01-21 10:34 ` Sebastian Tennant
2009-01-21 22:04 ` Stefan Monnier
2009-01-22 8:45 ` Sebastian Tennant
2009-01-22 15:09 ` Stefan Monnier
2009-01-22 18:07 ` Sebastian Tennant
2009-01-22 21:30 ` Stefan Monnier
2009-01-22 23:15 ` Sebastian Tennant
2009-01-23 7:53 ` Stefan Monnier
2009-01-23 10:46 ` Sebastian Tennant
2009-01-23 18:01 ` Sebastian Tennant
2009-01-25 17:58 ` Sebastian Tennant
2009-01-22 14:00 ` Sebastian Tennant
2009-01-22 18:27 ` Sebastian Tennant
2009-08-11 4:45 ` bug#1973: marked as done (Bug in simple.el (Emacs version 22.2.1)) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ljsu8uc1.fsf@vps203.linuxvps.org \
--to=sebyte@smolny.plus.com \
--cc=2103@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).