bug#1973: marked as done (Bug in simple.el (Emacs version 22.2.1))

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]


Your message dated Tue, 11 Aug 2009 00:40:04 -0400
with message-id <87ocqnneu3.fsf@cyd.mit.edu>
and subject line Re: Bug in simple.el (Emacs version 22.2.1)
has caused the Emacs bug report #1973,
regarding Bug in simple.el (Emacs version 22.2.1)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1973: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1973
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3785 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 352 bytes --]

Hello all,

Asynchronous commands called via shell-command, for example:

 (shell-command "apt-get update &")

fill the buffer *Async Shell Command Output* with Ctrl-Ms, which I'm
sure is not what's intended.

My patch (attached) fixes this by using make-comint-in-buffer, rather
than start-process, to call the asynchronous process.

HTH,

Sebastian


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: simple.el.diff --]
[-- Type: text/x-diff, Size: 730 bytes --]

--- /usr/share/emacs/22.2/lisp/simple-patched.el	2009-01-20 19:51:29.528333079 +0000
+++ /usr/share/emacs/22.2/lisp/simple.el	2008-03-11 01:57:32.000000000 +0000
@@ -1892,11 +1892,10 @@
 		  (erase-buffer)
 		  (display-buffer buffer)
 		  (setq default-directory directory)
-		  (setq proc (get-buffer-process
-			      (make-comint-in-buffer
-			       "Shell" buffer shell-file-name nil
-			       shell-command-switch command)))
+		  (setq proc (start-process "Shell" buffer shell-file-name
+					    shell-command-switch command))
 		  (setq mode-line-process '(":%s"))
+		  (require 'shell) (shell-mode)
 		  (set-process-sentinel proc 'shell-command-sentinel)
 		  ))
 	    (shell-command-on-region (point) (point) command

[-- Attachment #3: Type: message/rfc822, Size: 1072 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: 1973-done@emacsbugs.donarmstrong.com
Subject: Re: Bug in simple.el (Emacs version 22.2.1)
Date: Tue, 11 Aug 2009 00:40:04 -0400
Message-ID: <87ocqnneu3.fsf@cyd.mit.edu>

Closing Bug#1973, since async-shell-command is now in the trunk.