From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Tennant Newsgroups: gmane.emacs.bugs Subject: bug#2103: Bug in simple.el Date: Thu, 29 Jan 2009 07:06:22 +0000 Message-ID: References: <63k0dk26.fsf@vps203.linuxvps.org> Reply-To: Sebastian Tennant , 2103@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233213836 29927 80.91.229.12 (29 Jan 2009 07:23:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2009 07:23:56 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 29 08:25:10 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LSRGv-00041f-8g for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jan 2009 08:25:09 +0100 Original-Received: from localhost ([127.0.0.1]:42092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSRFc-0000wu-Pq for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jan 2009 02:23:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSRFX-0000wo-R8 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:23:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSRFU-0000wc-14 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:23:42 -0500 Original-Received: from [199.232.76.173] (port=56862 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSRFT-0000wZ-R1 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:23:39 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:39004) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LSRFT-0005m2-Df for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:23:39 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LSRFS-0003Bk-D8 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:23:38 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0T7NU3G006745; Wed, 28 Jan 2009 23:23:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0T7A4MK003377; Wed, 28 Jan 2009 23:10:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Sebastian Tennant Original-Sender: news Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 29 Jan 2009 07:10:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2103 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12332126881234 (code B ref -1); Thu, 29 Jan 2009 07:10:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 29 Jan 2009 07:04:48 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0T74cmN001228 for ; Wed, 28 Jan 2009 23:04:40 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSQx4-0008VH-72 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:04:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSQx2-0008Sr-Cy for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:04:36 -0500 Original-Received: from [199.232.76.173] (port=51414 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSQx2-0008Sf-23 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:04:36 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:47059 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LSQx1-0004oH-I0 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 02:04:35 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LSQwu-000337-KJ for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2009 07:04:28 +0000 Original-Received: from vps203.linuxvps.org ([91.186.7.203]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 29 Jan 2009 07:04:28 +0000 Original-Received: from sebyte by vps203.linuxvps.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 29 Jan 2009 07:04:28 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: vps203.linuxvps.org X-Host: localhost User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) Cancel-Lock: sha1:T1r0/tKM6YIaGxKNseh+3xw6Ur4= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Thu, 29 Jan 2009 02:23:42 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24706 Archived-At: Hi Stefan, Returning to the bug list, in case others have opinions on the matter... Quoth Stefan Monnier : >> Apologies for contacting you off-list. I'm doing so just in case you'd >> given up on me. My penultimate email to the Emacs bug list was >> something of a rant! >> >> Since then I think I've found the perfect solution. A hook needs to be >> added to simple.el providing ^M handling and we don't need to change >> anything in shell-command. >> >> http://article.gmane.org/gmane.emacs.help/61630 > > Hooks are great for users, but for internal use they're usually > better avoided since we can change the code directly instead. But in this case, some users may not want ^M handling, so providing a hook gives users the choice, no? > E.g. in this case we want to change shell-command. I agree that given the command is called 'shell-command' it would make sense for ^M characters to be handled in shell-like way, i.e., no ^Ms, in which case perhaps we should provide a spearate command for users who _don't_ want ^M handling; 'unfiltered-shell-command' or something like that? Then again, adding a hook and leaving shell-command as it stands is the simplest option and has the advantage of not breaking anything, i.e., no backward compatibility issues. Seb