bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook

bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook

[David Engster]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

In hideshow.el, there is a hook 'hs-show-hook' which should be run
whenever some text is shown again (i.e., unfolded).

However, the command hs-show-block does not run this hook; a (trivial)
patch which will fix this is attached.

Regards,
David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hideshow-patch.diff --]
[-- Type: text/x-diff, Size: 672 bytes --]

Index: hideshow.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v
retrieving revision 1.80
diff -u -r1.80 hideshow.el
--- hideshow.el	14 Aug 2009 23:02:41 -0000	1.80
+++ hideshow.el	24 Sep 2009 13:28:55 -0000
@@ -869,8 +869,8 @@
                    q (progn (hs-forward-sexp (match-data t) 1) (point)))))
       (when (and p q)
         (hs-discard-overlays p q)
-        (goto-char (if end q (1+ p)))))
-    (run-hooks 'hs-show-hook))))
+        (goto-char (if end q (1+ p))))))
+   (run-hooks 'hs-show-hook)))
 
 (defun hs-hide-level (arg)
   "Hide all blocks ARG levels below this block.

bug#4548: marked as done (23.1.50; hideshow.el - hs-show-block does not run hs-show-hook)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

Your message dated Fri, 25 Sep 2009 02:33:10 +0200
with message-id <f7ccd24b0909241733h3f4848a1m5a77ba89c96ab0bf@mail.gmail.com>
and subject line Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run  hs-show-hook
has caused the Emacs bug report #4548,
regarding 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4548: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4548
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3014 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 247 bytes --]

In hideshow.el, there is a hook 'hs-show-hook' which should be run
whenever some text is shown again (i.e., unfolded).

However, the command hs-show-block does not run this hook; a (trivial)
patch which will fix this is attached.

Regards,
David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: hideshow-patch.diff --]
[-- Type: text/x-diff, Size: 672 bytes --]

Index: hideshow.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v
retrieving revision 1.80
diff -u -r1.80 hideshow.el
--- hideshow.el	14 Aug 2009 23:02:41 -0000	1.80
+++ hideshow.el	24 Sep 2009 13:28:55 -0000
@@ -869,8 +869,8 @@
                    q (progn (hs-forward-sexp (match-data t) 1) (point)))))
       (when (and p q)
         (hs-discard-overlays p q)
-        (goto-char (if end q (1+ p)))))
-    (run-hooks 'hs-show-hook))))
+        (goto-char (if end q (1+ p))))))
+   (run-hooks 'hs-show-hook)))
 
 (defun hs-hide-level (arg)
   "Hide all blocks ARG levels below this block.

[-- Attachment #3: Type: message/rfc822, Size: 2484 bytes --]

From: Juanma Barranquero <lekktu@gmail.com>
To: David Engster <deng@randomsample.de>
Cc: 4548-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run  hs-show-hook
Date: Fri, 25 Sep 2009 02:33:10 +0200
Message-ID: <f7ccd24b0909241733h3f4848a1m5a77ba89c96ab0bf@mail.gmail.com>

On Thu, Sep 24, 2009 at 15:35, David Engster <deng@randomsample.de> wrote:

> However, the command hs-show-block does not run this hook; a (trivial)
> patch which will fix this is attached.

Committed, thanks.

    Juanma