From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4548: marked as done (23.1.50; hideshow.el - hs-show-block does not run hs-show-hook) Date: Fri, 25 Sep 2009 00:40:05 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1253839205-26072-0" X-Trace: ger.gmane.org 1253839648 26580 80.91.229.12 (25 Sep 2009 00:47:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Sep 2009 00:47:28 +0000 (UTC) To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 25 02:47:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mqyxz-0006ir-N1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Sep 2009 02:47:20 +0200 Original-Received: from localhost ([127.0.0.1]:50658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mqyxz-0007Ar-2V for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 20:47:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mqyxu-0007Am-Bt for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 20:47:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mqyxo-0007AY-KG for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 20:47:12 -0400 Original-Received: from [199.232.76.173] (port=48455 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mqyxo-0007AT-GO for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 20:47:08 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50408) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mqyxn-0004Qk-RZ for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 20:47:08 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8P0l4TJ027200; Thu, 24 Sep 2009 17:47:04 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8P0e5ck026077; Thu, 24 Sep 2009 17:40:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4548 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31481 Archived-At: This is a multi-part message in MIME format... ------------=_1253839205-26072-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 25 Sep 2009 02:33:10 +0200 with message-id and subject line Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does no= t run hs-show-hook has caused the Emacs bug report #4548, regarding 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4548: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4548 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1253839205-26072-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 24 Sep 2009 13:35:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8ODZL0E020124 for ; Thu, 24 Sep 2009 06:35:23 -0700 Received: from mx10.gnu.org ([199.232.76.166]:44823) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MqoTh-0001tj-4T for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:21 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MqoTf-0004Bq-C5 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:20 -0400 Received: from m61s02.vlinux.de ([83.151.21.164]:38453) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqoTf-0004BK-2A for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 09:35:19 -0400 Received: from kafka.physik3.gwdg.de ([134.76.92.48] helo=kafka) by m61s02.vlinux.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1MqoTb-0001cW-K6 for emacs-pretest-bug@gnu.org; Thu, 24 Sep 2009 15:35:15 +0200 From: David Engster To: emacs-pretest-bug@gnu.org Subject: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook Date: Thu, 24 Sep 2009 15:35:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) --=-=-= In hideshow.el, there is a hook 'hs-show-hook' which should be run whenever some text is shown again (i.e., unfolded). However, the command hs-show-block does not run this hook; a (trivial) patch which will fix this is attached. Regards, David --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=hideshow-patch.diff Index: hideshow.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/hideshow.el,v retrieving revision 1.80 diff -u -r1.80 hideshow.el --- hideshow.el 14 Aug 2009 23:02:41 -0000 1.80 +++ hideshow.el 24 Sep 2009 13:28:55 -0000 @@ -869,8 +869,8 @@ q (progn (hs-forward-sexp (match-data t) 1) (point))))) (when (and p q) (hs-discard-overlays p q) - (goto-char (if end q (1+ p))))) - (run-hooks 'hs-show-hook)))) + (goto-char (if end q (1+ p)))))) + (run-hooks 'hs-show-hook))) (defun hs-hide-level (arg) "Hide all blocks ARG levels below this block. --=-=-=-- ------------=_1253839205-26072-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4548-done) by emacsbugs.donarmstrong.com; 25 Sep 2009 00:33:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8P0Xak8025170 for <4548-done@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 17:33:37 -0700 Received: by fxm3 with SMTP id 3so1860575fxm.44 for <4548-done@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 17:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=PStBvzLp9vkMSPOrjRsXUOl8fmS2Q3Lr8u7Ru4Lbphw=; b=Rc0dZqB1Bf7osqowwf1JWNyN3GuITg6834c2h62xLfnJoQWas6X/ln+sQt3s84x2iK RHpCpCd4vcNme3YRSg1CZcwuRWOYUtDfB+RHtJSqA683Bu4DYXf+W5h/JfboH/RONlKh t8WsZUYn3myaVf6oLpukXH18HhrA3cYF+5qks= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=gmC/HnBYjJuJsrkpLJylzS5Dlao9KhWAyct91nS3uRrjMe20nDJvyEX0T95mCDSq3P f4RRRWz6X3P5+4EAUX3q/D0/DTpevy2oTGvA3dUJy3SevmhHIJBe0SNBPoeWliKI9AGx usMTq659fWrjEZ8ID6tUkTRFIUUSsK60ocp7c= MIME-Version: 1.0 Received: by 10.239.139.104 with SMTP id s40mr354913hbs.76.1253838810137; Thu, 24 Sep 2009 17:33:30 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 25 Sep 2009 02:33:10 +0200 Message-ID: Subject: Re: bug#4548: 23.1.50; hideshow.el - hs-show-block does not run hs-show-hook To: David Engster Cc: 4548-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=UTF-8 On Thu, Sep 24, 2009 at 15:35, David Engster wrote: > However, the command hs-show-block does not run this hook; a (trivial) > patch which will fix this is attached. Committed, thanks. Juanma ------------=_1253839205-26072-0--