From: Glenn Morris <rgm@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 24714@debbugs.gnu.org
Subject: bug#24714: delete-directory race condition
Date: Tue, 18 Oct 2016 12:55:55 -0400 [thread overview]
Message-ID: <jyeg3dzjdw.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <0fef1f0c-3730-9962-5dbd-a114d465a7b2@cs.ucla.edu> (Paul Eggert's message of "Tue, 18 Oct 2016 09:44:56 -0700")
I haven't tested it, but the files--force implementation looks a little
unaesthetic to me. Did you consider adding a standard condition error in
report_file_errno for ENOENT? There would then be symmetry with the
file-already-exists error for EEXIST.
Also, IMO this is purely a bug fix, and should not be mentioned in NEWS,
the lispref, or the doc.
But thanks for the fix!
next prev parent reply other threads:[~2016-10-18 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 2:20 bug#24714: delete-directory race condition Glenn Morris
2016-10-17 6:19 ` Eli Zaretskii
2016-10-17 15:52 ` Glenn Morris
2016-10-17 16:11 ` Eli Zaretskii
2016-10-17 17:00 ` Andreas Schwab
2016-10-18 16:50 ` Glenn Morris
2016-10-18 16:44 ` Paul Eggert
2016-10-18 16:55 ` Glenn Morris [this message]
2016-10-18 16:59 ` Glenn Morris
2016-10-19 7:23 ` Eli Zaretskii
2016-10-20 6:50 ` Paul Eggert
2016-10-21 11:53 ` Daniel Colascione
2016-10-21 12:09 ` Andreas Schwab
2016-10-21 12:10 ` Daniel Colascione
2016-10-21 12:55 ` Eli Zaretskii
2016-10-21 20:07 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jyeg3dzjdw.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=24714@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).