From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#24714: delete-directory race condition Date: Tue, 18 Oct 2016 12:55:55 -0400 Message-ID: References: <0fef1f0c-3730-9962-5dbd-a114d465a7b2@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1476809843 24531 195.159.176.226 (18 Oct 2016 16:57:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 16:57:23 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 24714@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 18:57:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXhO-0004xw-P9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 18:57:10 +0200 Original-Received: from localhost ([::1]:42921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwXhR-0006jW-17 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 12:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwXhH-0006hD-BZ for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwXhG-0003lF-LD for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:57:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwXhG-0003lB-IG for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwXhG-000736-Ch for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24714-submit@debbugs.gnu.org id=B24714.147680976727029 (code B ref 24714); Tue, 18 Oct 2016 16:57:02 +0000 Original-Received: (at 24714) by debbugs.gnu.org; 18 Oct 2016 16:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:38315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXgM-00071t-RW for submit@debbugs.gnu.org; Tue, 18 Oct 2016 12:56:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwXgL-00071P-A7 for 24714@debbugs.gnu.org; Tue, 18 Oct 2016 12:56:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwXgF-00039z-CN for 24714@debbugs.gnu.org; Tue, 18 Oct 2016 12:56:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwXgC-00038R-Jq; Tue, 18 Oct 2016 12:55:56 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bwXgB-0008Jo-P2; Tue, 18 Oct 2016 12:55:55 -0400 X-Spook: USCG munitions MD5 Virual Hemorrhagic Fever Spammer Sears X-Ran: %peX#@Wd[V->4fv=jU%,f8]iu9DYwIEGdEk4#$D#6`Al+(M9"<6Q%H&Q>84w1S);sS9}[C X-Hue: magenta X-Attribution: GM In-Reply-To: <0fef1f0c-3730-9962-5dbd-a114d465a7b2@cs.ucla.edu> (Paul Eggert's message of "Tue, 18 Oct 2016 09:44:56 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124644 Archived-At: I haven't tested it, but the files--force implementation looks a little unaesthetic to me. Did you consider adding a standard condition error in report_file_errno for ENOENT? There would then be symmetry with the file-already-exists error for EEXIST. Also, IMO this is purely a bug fix, and should not be mentioned in NEWS, the lispref, or the doc. But thanks for the fix!