unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 24714@debbugs.gnu.org
Subject: bug#24714: delete-directory race condition
Date: Tue, 18 Oct 2016 12:50:32 -0400	[thread overview]
Message-ID: <sinspzjmv.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87shruj4fs.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 17 Oct 2016 19:00:55 +0200")

Andreas Schwab wrote:

> That is ok.  The operation cannot successfully be completed in this case.
>
>> Frankly I don't see how Emacs's delete-directory can work reliably as
>> currently implemented.
>
> A property it shares with any other operation recursing on directories,
> in Emacs or elsewhere.

That's interesting. I'd assumed there was a "Right Way" to do it, and
that it would be whatever coreutil's rm did. If not then we are back to:

> delete-directory should simply catch ENOENT errors and ignore them
> when it deletes files and subdirectories under the "recursive" option.
> Other errors should signal an error as they do now.

This doesn't seem possible without changes at the C level.
Should there be a standard Lisp error for ENOENT?
Currently report_file_errno only does EEXIST -> file_already_exists.

Or should delete-file get a FORCE argument akin to "rm -f"?





  reply	other threads:[~2016-10-18 16:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17  2:20 bug#24714: delete-directory race condition Glenn Morris
2016-10-17  6:19 ` Eli Zaretskii
2016-10-17 15:52   ` Glenn Morris
2016-10-17 16:11     ` Eli Zaretskii
2016-10-17 17:00     ` Andreas Schwab
2016-10-18 16:50       ` Glenn Morris [this message]
2016-10-18 16:44 ` Paul Eggert
2016-10-18 16:55   ` Glenn Morris
2016-10-18 16:59     ` Glenn Morris
2016-10-19  7:23       ` Eli Zaretskii
2016-10-20  6:50         ` Paul Eggert
2016-10-21 11:53         ` Daniel Colascione
2016-10-21 12:09           ` Andreas Schwab
2016-10-21 12:10             ` Daniel Colascione
2016-10-21 12:55           ` Eli Zaretskii
2016-10-21 20:07     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sinspzjmv.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=24714@debbugs.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).