From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: npostavs@users.sourceforge.net
Cc: lekktu@gmail.com, johnw@gnu.org, 6991@debbugs.gnu.org, larsi@gnus.org
Subject: bug#6991: Please keep bytecode out of *Backtrace* buffers
Date: Sun, 25 Jun 2017 15:11:02 -0400 [thread overview]
Message-ID: <jwvzicwaxwx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87o9tdowbh.fsf@users.sourceforge.net> (npostavs's message of "Sat, 24 Jun 2017 18:27:46 -0400")
> I made use of cl-prin1 depend on a custom option, and replace NUL bytes
> also in w32. I think this is ready to merge now, I will probably do so
> sometime next week.
A few questions below.
> + (when fun-file
> + (make-text-button fun-pt (+ fun-pt (length (symbol-name fun)))
> + :type 'help-function-def
> + 'help-args (list fun fun-file))))
Hmm... this looks like code which was moved from elsewhere, yet I can't
find this elsewhere in your patch(es).
I think that other code is in debugger-make-xrefs, so can't we remove
debugger-make-xrefs?
> + (let ((frames (nthcdr
> + ;; Remove debug--implement-debug-on-entry and the
> + ;; advice's `apply' frame.
> + (if (eq (car args) 'debug) 3 1)
> + (backtrace-frames 'debug)))
> + (print-escape-newlines t)
> + (print-level 8)
> + (print-length 50))
Why let-bind print-* here rather than inside debugger-insert-backtrace?
> + (when (eq (car args) 'exit)
> + (setf (cl-getf (nth 3 (car frames)) :debug-on-exit) nil))
This looks like code which was moved from elsewhere, yet I can't find
this elsewhere in your patch(es). What am I missing?
> + (pcase (help-split-fundoc (documentation object 'raw) object)
> + (`(,_ . ,(and doc (guard (stringp doc))))
> + (princ " " stream)
> + (prin1 doc stream)))
Maybe this deserves a one-line comment explaining that the arglist part
was already printed via help-function-arglist.
> +(defcustom debugger-print-function #'cl-prin1
> + "Function used to print values in the debugger backtraces."
> + :type 'function
> + :options '(cl-prin1 prin1)
> + :group 'debugger
> + :version "26.1")
The `:group 'debugger` is redundant (as is the case for all defcustom
in this file).
> +(defvar cl-print-compiled)
Is this used somewhere?
> - (prin1 fun)
> - (if args (prin1 args) (princ "()")))
> + (funcall debugger-print-function fun)
> + (if args (cl-prin1 args) (princ "()")))
This `cl-prin1` should be replaced with debugger-print-function, right?
Stefan
next prev parent reply other threads:[~2017-06-25 19:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 1:35 bug#6991: Please keep bytecode out of *Backtrace* buffers jidanni
2012-02-22 1:02 ` Glenn Morris
2012-02-22 16:43 ` Drew Adams
2012-02-22 17:01 ` Juanma Barranquero
2012-07-02 17:40 ` Drew Adams
2012-07-02 18:38 ` Stefan Monnier
2012-07-02 19:06 ` Drew Adams
2013-01-24 22:43 ` Drew Adams
[not found] ` <<FEE817DF5DCC41CD9156B414FF2088D1@us.oracle.com>
2013-08-07 22:25 ` Drew Adams
2016-02-26 6:41 ` Lars Ingebrigtsen
2016-02-26 14:11 ` Drew Adams
2016-02-27 0:52 ` John Wiegley
2016-02-27 1:49 ` Drew Adams
2016-11-19 1:55 ` npostavs
2016-11-19 2:37 ` Drew Adams
2016-11-19 7:41 ` Eli Zaretskii
2016-11-19 14:39 ` npostavs
2016-11-19 15:07 ` Eli Zaretskii
2016-11-19 15:20 ` npostavs
2016-11-19 18:34 ` Eli Zaretskii
2016-11-19 22:33 ` npostavs
2016-11-20 15:46 ` Eli Zaretskii
2016-11-22 18:07 ` Noam Postavsky
2016-11-22 18:52 ` Eli Zaretskii
2016-11-22 21:07 ` Noam Postavsky
2016-11-23 16:05 ` Eli Zaretskii
2016-11-26 17:18 ` npostavs
2016-11-26 18:54 ` Stefan Monnier
2017-02-12 2:26 ` npostavs
2017-05-28 14:58 ` npostavs
2017-06-24 22:27 ` npostavs
2017-06-25 19:11 ` Stefan Monnier [this message]
2017-06-26 3:34 ` npostavs
2017-06-26 4:02 ` Stefan Monnier
2017-06-26 12:50 ` npostavs
2017-06-26 14:54 ` Stefan Monnier
2017-06-27 3:56 ` npostavs
2017-06-27 16:18 ` Stefan Monnier
2017-06-29 23:52 ` npostavs
2016-11-26 23:45 ` Richard Stallman
2016-11-27 0:33 ` Noam Postavsky
2016-11-27 3:34 ` Clément Pit--Claudel
2016-11-27 3:36 ` Eli Zaretskii
2016-11-27 14:10 ` Noam Postavsky
2016-11-27 23:21 ` Richard Stallman
2016-11-19 17:08 ` Richard Stallman
2016-02-27 4:13 ` Lars Ingebrigtsen
2017-09-11 10:57 ` bug#6991: Rocky Bernstein
2017-09-11 14:28 ` bug#6991: Eli Zaretskii
2017-09-13 1:13 ` bug#6991: Rocky Bernstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzicwaxwx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6991@debbugs.gnu.org \
--cc=johnw@gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).