From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: Knut Anders Hatlen <kahatlen@gmail.com>, 60411@debbugs.gnu.org
Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil
Date: Sun, 01 Jan 2023 12:00:25 -0500 [thread overview]
Message-ID: <jwvv8lqmbtk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <0a62cbaeff1ee0497715@heytings.org> (Gregory Heytings's message of "Sat, 31 Dec 2022 15:02:57 +0000")
> @@ -2275,8 +2275,14 @@ display-completion-list
>
> (with-current-buffer standard-output
> (goto-char (point-max))
> - (when completions-header-format
> + (when (stringp completions-header-format)
> (insert (format completions-header-format (length completions))))
> + (when (or (not (stringp completions-header-format))
> + (string= completions-header-format ""))
> + ;; Insert an invisible line, otherwise the first call to
> + ;; 'minibuffer-next-completion' might select the second
> + ;; completion candidate. See bug#60411.
> + (insert (propertize "\n" 'invisible t)))
> (completion--insert-strings completions group-fun)))
>
> (run-hooks 'completion-setup-hook)
Yuck. I get the impression that it would be cleaner to fix "the first
call to `minibuffer-next-completion`" instead.
Stefan
next prev parent reply other threads:[~2023-01-01 17:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 21:25 bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Knut Anders Hatlen
2022-12-30 8:11 ` Eli Zaretskii
2022-12-30 11:04 ` Knut Anders Hatlen
2022-12-30 21:54 ` Gregory Heytings
2022-12-31 6:27 ` Knut Anders Hatlen
2022-12-31 15:02 ` Gregory Heytings
2022-12-31 15:33 ` Knut Anders Hatlen
2022-12-31 15:35 ` Gregory Heytings
2022-12-31 16:40 ` Eli Zaretskii
2023-01-01 17:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-01 17:05 ` Gregory Heytings
2023-01-01 17:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 18:56 ` Gregory Heytings
2023-01-05 17:37 ` Juri Linkov
2023-01-05 21:04 ` Gregory Heytings
2023-01-06 6:43 ` Eli Zaretskii
2023-01-06 8:22 ` Gregory Heytings
2023-01-06 8:52 ` Eli Zaretskii
2023-01-06 9:01 ` Gregory Heytings
2023-01-06 11:40 ` Eli Zaretskii
2023-01-06 12:13 ` Gregory Heytings
2023-01-06 12:21 ` Eli Zaretskii
2023-01-06 12:39 ` Gregory Heytings
2023-01-06 12:59 ` Eli Zaretskii
2023-01-06 13:10 ` Gregory Heytings
2023-01-06 13:26 ` Eli Zaretskii
2023-01-06 17:07 ` Gregory Heytings
2023-01-06 18:05 ` Eli Zaretskii
2023-01-06 18:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 18:51 ` Gregory Heytings
2023-01-07 18:11 ` Juri Linkov
2023-01-07 18:15 ` Juri Linkov
2023-01-07 22:35 ` Gregory Heytings
2023-01-08 8:42 ` Juri Linkov
2023-01-08 22:43 ` Gregory Heytings
2023-01-12 17:48 ` Juri Linkov
2023-01-06 17:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 18:11 ` Eli Zaretskii
2023-01-06 18:49 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv8lqmbtk.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=60411@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=kahatlen@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).