unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Gregory Heytings <gregory@heytings.org>
Cc: Knut Anders Hatlen <kahatlen@gmail.com>,
	60411@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil
Date: Thu, 05 Jan 2023 19:37:34 +0200	[thread overview]
Message-ID: <86sfgp5ihl.fsf@mail.linkov.net> (raw)
In-Reply-To: <226b32f79f65b964c636@heytings.org> (Gregory Heytings's message of "Sun, 01 Jan 2023 18:56:30 +0000")

>> I think the crux of the matter is that the state in which we are at the
>> beginning (when creating the *Completions* buffer) is unclear/accidental
>> (is the first completion already selected or not?).
>
> Exactly.
>
>> It's not clear to me how to "make this right", but maybe a "better ugly
>> hack" is to work with the above `setq-local`, i.e. if
>> `cursor-face-highlight-nonselected-window` is still nil (in which case,
>> the cursor-face hilighting should be currently off), consider that
>> `minibuffer-next-completion` should move to the *first* completion rather
>> than to the next.
>
> I thought about that solution, but what if someone sets
> completion-highlight-face to nil?  I also tried to add another buffer-local
> variable to distinguish the first and later calls to
> minibuffer-next-completion, but that didn't work in all cases either.

Then I guess your insert-invisible-\n patch is the simplest way
to enforce such a long-standing rule that no candidate is selected
in the completions buffer initially, even when it has no visible header.
And definitely this is the safest solution for the release branch.





  reply	other threads:[~2023-01-05 17:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 21:25 bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Knut Anders Hatlen
2022-12-30  8:11 ` Eli Zaretskii
2022-12-30 11:04   ` Knut Anders Hatlen
2022-12-30 21:54 ` Gregory Heytings
2022-12-31  6:27   ` Knut Anders Hatlen
2022-12-31 15:02     ` Gregory Heytings
2022-12-31 15:33       ` Knut Anders Hatlen
2022-12-31 15:35         ` Gregory Heytings
2022-12-31 16:40       ` Eli Zaretskii
2023-01-01 17:00       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 17:05         ` Gregory Heytings
2023-01-01 17:55           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01 18:56             ` Gregory Heytings
2023-01-05 17:37               ` Juri Linkov [this message]
2023-01-05 21:04                 ` Gregory Heytings
2023-01-06  6:43                   ` Eli Zaretskii
2023-01-06  8:22                     ` Gregory Heytings
2023-01-06  8:52                       ` Eli Zaretskii
2023-01-06  9:01                         ` Gregory Heytings
2023-01-06 11:40                           ` Eli Zaretskii
2023-01-06 12:13                             ` Gregory Heytings
2023-01-06 12:21                               ` Eli Zaretskii
2023-01-06 12:39                                 ` Gregory Heytings
2023-01-06 12:59                                   ` Eli Zaretskii
2023-01-06 13:10                                     ` Gregory Heytings
2023-01-06 13:26                                       ` Eli Zaretskii
2023-01-06 17:07                                         ` Gregory Heytings
2023-01-06 18:05                                           ` Eli Zaretskii
2023-01-06 18:23                                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 18:51                                               ` Gregory Heytings
2023-01-07 18:11                                           ` Juri Linkov
2023-01-07 18:15                                             ` Juri Linkov
2023-01-07 22:35                                               ` Gregory Heytings
2023-01-08  8:42                                                 ` Juri Linkov
2023-01-08 22:43                                                   ` Gregory Heytings
2023-01-12 17:48                                                 ` Juri Linkov
2023-01-06 17:51                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 18:11                                   ` Eli Zaretskii
2023-01-06 18:49                                   ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sfgp5ihl.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=60411@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=kahatlen@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).