From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Date: Sun, 01 Jan 2023 12:00:25 -0500 Message-ID: References: <87zgb5lx6y.fsf@oracle.com> <6c9d91cffcdbff97f034@heytings.org> <87lemot7ek.fsf@gmail.com> <0a62cbaeff1ee0497715@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16432"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Knut Anders Hatlen , 60411@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 18:03:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC1k0-00042f-Df for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 18:03:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC1hr-0007S9-0M; Sun, 01 Jan 2023 12:01:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC1hn-0007OS-1K for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC1hm-0008Va-FZ for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC1hm-0003Dt-2T for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 12:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60411 X-GNU-PR-Package: emacs Original-Received: via spool by 60411-submit@debbugs.gnu.org id=B60411.167259243612342 (code B ref 60411); Sun, 01 Jan 2023 17:01:02 +0000 Original-Received: (at 60411) by debbugs.gnu.org; 1 Jan 2023 17:00:36 +0000 Original-Received: from localhost ([127.0.0.1]:41605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1hL-0003Cz-UK for submit@debbugs.gnu.org; Sun, 01 Jan 2023 12:00:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC1hJ-0003Cm-NU for 60411@debbugs.gnu.org; Sun, 01 Jan 2023 12:00:34 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ED46080937; Sun, 1 Jan 2023 12:00:27 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 48A5880820; Sun, 1 Jan 2023 12:00:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672592426; bh=8vFtgiZW+nco9vtPc7uJAClaaaS455uAY6r0VhtdgPg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X5WcXdiw7P4JTi4mxykRACx42Hy5DGBeQ50zdJx8i5E/qC3taRWRlbVk1BpCg9Rgd NZe57yNp/HDEt1spKho0zsH6YGpBvqYS5mswW+yPe1dbLBaCZjAXo+al1lWrxIe0CI 3d556hFbVcTTzqGelzbnjkERHmEB1R1ydsASq4rYsDRdi30D70k6ui8cywdDOwwVz4 TExSwD5TMWRleODfzMchCUb9FN+XrjSdqNNSgWD3yEZiScxWm/Cqdxy1llqCy1seBq P7aEd/Q1vD2yRWUOFkDXm+G8/8kTLs6EwvWmSGY3o0vwHmMXD3lrjsTlxYBGJqaEg0 ako82uPCQ0/wg== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1C04C1200FC; Sun, 1 Jan 2023 12:00:26 -0500 (EST) In-Reply-To: <0a62cbaeff1ee0497715@heytings.org> (Gregory Heytings's message of "Sat, 31 Dec 2022 15:02:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252253 Archived-At: > @@ -2275,8 +2275,14 @@ display-completion-list > > (with-current-buffer standard-output > (goto-char (point-max)) > - (when completions-header-format > + (when (stringp completions-header-format) > (insert (format completions-header-format (length completions)))) > + (when (or (not (stringp completions-header-format)) > + (string= completions-header-format "")) > + ;; Insert an invisible line, otherwise the first call to > + ;; 'minibuffer-next-completion' might select the second > + ;; completion candidate. See bug#60411. > + (insert (propertize "\n" 'invisible t))) > (completion--insert-strings completions group-fun))) > > (run-hooks 'completion-setup-hook) Yuck. I get the impression that it would be cleaner to fix "the first call to `minibuffer-next-completion`" instead. Stefan