unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63956@debbugs.gnu.org, Jeff Norden <norden.jeff@gmail.com>, sds@gnu.org
Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29
Date: Mon, 12 Jun 2023 21:34:19 -0400	[thread overview]
Message-ID: <jwvttvcrw4l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pm61yigx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Jun 2023 21:14:22 +0300")

> You could be right, but I couldn't find any callers of that function,
> so it was hard for me to reason about that specific case.  Stefan,
> since you introduced tex-cmd-doc-view into tex-mode.el, could you take
> a look and tell whether using display-tex-shell-buffer-action in its
> default value there makes sense?  If not, what would be a better
> default?

Hmm... when I introduced `tex-cmd-doc-view` it just used

    (pop-to-buffer (find-file-noselect file))

then when Sam Steingold introduced `display-comint-buffer-action` (in
commit 18b680cfd177) he used it there as well, but I suspect this was
a mistake because that command does not at all work like a comint thingy
(my guess is that he's an AUCTeX user and just assumed that
`tex-cmd-doc-view` is like other `tex-cmd-*` thingies).

I'm not sure it's harmful to use `display-comint-buffer-action` or
`display-tex-shell-buffer-action` there (e.g. I haven't noticed it being
a problem in my own use since Sam's patch), but it doesn't seem
necessary nor very natural (it's just not a "tex-shell" or "comint"
buffer, it's a normal file buffer).


        Stefan






  parent reply	other threads:[~2023-06-13  1:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 17:52 bug#63956: 29.0.91; tex-mode display problem in emacs-29 Jeff Norden
2023-06-08  9:15 ` Eli Zaretskii
2023-06-08 17:44   ` Sam Steingold
2023-06-08 18:34     ` Eli Zaretskii
2023-06-09 20:00       ` Sam Steingold
2023-06-10  5:56         ` Eli Zaretskii
2023-06-10 12:55           ` Gregory Heytings
2023-06-10 13:12             ` Eli Zaretskii
2023-06-10 13:20               ` Gregory Heytings
2023-06-11  6:22           ` Eli Zaretskii
2023-06-11 15:44             ` Jeff Norden
2023-06-11 16:01               ` Eli Zaretskii
2023-06-11 17:31                 ` Jeff Norden
2023-06-11 18:14                   ` Eli Zaretskii
2023-06-11 20:12                     ` Jeff Norden
2023-06-12 11:49                       ` Eli Zaretskii
2023-06-12 16:41                         ` Jeff Norden
2023-06-12 16:44                           ` Eli Zaretskii
2023-06-13  1:34                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-13 11:12                       ` Eli Zaretskii
2023-06-09 16:30   ` Jeff Norden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvttvcrw4l.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=63956@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=norden.jeff@gmail.com \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).