From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Date: Mon, 12 Jun 2023 21:34:19 -0400 Message-ID: References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24076"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63956@debbugs.gnu.org, Jeff Norden , sds@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 13 03:35:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8swI-00061K-8g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jun 2023 03:35:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8sw4-0003ld-P2; Mon, 12 Jun 2023 21:35:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8sw2-0003lH-PX for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 21:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8sw2-0002zs-FZ for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 21:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q8sw1-0007nV-Uv for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2023 21:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 01:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs Original-Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168662007229936 (code B ref 63956); Tue, 13 Jun 2023 01:35:01 +0000 Original-Received: (at 63956) by debbugs.gnu.org; 13 Jun 2023 01:34:32 +0000 Original-Received: from localhost ([127.0.0.1]:41006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8svX-0007mk-PZ for submit@debbugs.gnu.org; Mon, 12 Jun 2023 21:34:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8svT-0007mT-Qy for 63956@debbugs.gnu.org; Mon, 12 Jun 2023 21:34:31 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 72439442A86; Mon, 12 Jun 2023 21:34:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0F9F8442A7D; Mon, 12 Jun 2023 21:34:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1686620061; bh=NLwzsBiaDsBXTke0hjtpcfB2ihfupuYL7zBfiNPsHN4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=D5goovHy/E1PvmAF+Lj03dJI6VCQ0aT/jXGU4/oyw60tvjSngwZReV12X88Ga2cf1 rgwUtr22hOBhs7vCarE52dhCV5cTRynWtc/pvryc8QNIF9URrkHuQYt3MaeKOj/B2A DmGXt9nO0c2FBp9jtXiu+nUc/rLMOYXVA0penD2Bn3VIsqCqcM6IsOIDIggeb+OfV7 cC9srj18fgEBUZSRNuLEbVBmY/saBiIAFmTsz7mFzKuO5ey63JSljOtvG+KIJLAtGX vdSqA88mJd1qB34yOnUC7X9J4x66zS7QXPNCTypIfwaCt7THDkpHmzrb8vv11rPU7r WItFeEeC4z2jw== Original-Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC6D21204BA; Mon, 12 Jun 2023 21:34:20 -0400 (EDT) In-Reply-To: <83pm61yigx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Jun 2023 21:14:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263300 Archived-At: > You could be right, but I couldn't find any callers of that function, > so it was hard for me to reason about that specific case. Stefan, > since you introduced tex-cmd-doc-view into tex-mode.el, could you take > a look and tell whether using display-tex-shell-buffer-action in its > default value there makes sense? If not, what would be a better > default? Hmm... when I introduced `tex-cmd-doc-view` it just used (pop-to-buffer (find-file-noselect file)) then when Sam Steingold introduced `display-comint-buffer-action` (in commit 18b680cfd177) he used it there as well, but I suspect this was a mistake because that command does not at all work like a comint thingy (my guess is that he's an AUCTeX user and just assumed that `tex-cmd-doc-view` is like other `tex-cmd-*` thingies). I'm not sure it's harmful to use `display-comint-buffer-action` or `display-tex-shell-buffer-action` there (e.g. I haven't noticed it being a problem in my own use since Sam's patch), but it doesn't seem necessary nor very natural (it's just not a "tex-shell" or "comint" buffer, it's a normal file buffer). Stefan