unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sds@gnu.org, norden.jeff@gmail.com
Cc: 63956-done@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29
Date: Sun, 11 Jun 2023 09:22:41 +0300	[thread overview]
Message-ID: <837csazff2.fsf@gnu.org> (raw)
In-Reply-To: <837csb2731.fsf@gnu.org> (message from Eli Zaretskii on Sat, 10 Jun 2023 08:56:50 +0300)

> Cc: 63956@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 10 Jun 2023 08:56:50 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Maybe `display-comint-buffer-action' should default to
> > `display-buffer-in-previous-window'?
> 
> That works for me, but I think it's too late to change the default
> now, 1.5 years after the defcustom was introduced.  (It could be a
> good idea for master, perhaps.)  So at this point, on the release
> branch, I'd like to fix only the specific problems we see, without
> risking any unrelated breakage.  To understand how best to solve this,
> I need you two (and anyone else who uses tex-mode) to look at the
> other uses of this defcustom in tex-mode, and tell me whether any of
> them also need fixing.  As I wrote in my original message:
> 
> > Jeff, would you please look at the 3 places in tex-mode where
> > display-comint-buffer-action was added to calls to pop-to-buffer and
> > display-buffer, and tell in which ones showing the buffer in the same
> > window by default makes sense?  I don't myself use tex-mode, so it is
> > hard for me to tell.  We could then discuss whether to remove the
> > argument in some of the cases or make a tex-mode-specific user option
> > to let users control that.  For example, in the specific case of
> > tex-display-shell it sounds like just dropping the argument would be
> > TRT, since all of its callers want to show the shell buffer, but not
> > in the selected window.  What about the other two cases where this
> > argument was added?
> 
> Would you two please help me understand how best to fix this
> regression by providing the above information?  TIA.

No further comments, so I've now added a new defcustom, called
display-tex-shell-buffer-action, and made its default value be
display-buffer-in-previous-window.  With that, I'm closing this bug.





  parent reply	other threads:[~2023-06-11  6:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 17:52 bug#63956: 29.0.91; tex-mode display problem in emacs-29 Jeff Norden
2023-06-08  9:15 ` Eli Zaretskii
2023-06-08 17:44   ` Sam Steingold
2023-06-08 18:34     ` Eli Zaretskii
2023-06-09 20:00       ` Sam Steingold
2023-06-10  5:56         ` Eli Zaretskii
2023-06-10 12:55           ` Gregory Heytings
2023-06-10 13:12             ` Eli Zaretskii
2023-06-10 13:20               ` Gregory Heytings
2023-06-11  6:22           ` Eli Zaretskii [this message]
2023-06-11 15:44             ` Jeff Norden
2023-06-11 16:01               ` Eli Zaretskii
2023-06-11 17:31                 ` Jeff Norden
2023-06-11 18:14                   ` Eli Zaretskii
2023-06-11 20:12                     ` Jeff Norden
2023-06-12 11:49                       ` Eli Zaretskii
2023-06-12 16:41                         ` Jeff Norden
2023-06-12 16:44                           ` Eli Zaretskii
2023-06-13  1:34                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-13 11:12                       ` Eli Zaretskii
2023-06-09 16:30   ` Jeff Norden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837csazff2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63956-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=norden.jeff@gmail.com \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).