From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44070@debbugs.gnu.org
Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit
Date: Sat, 31 Oct 2020 09:12:16 -0400 [thread overview]
Message-ID: <jwvsg9u7dcb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83sg9uhjy2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Oct 2020 10:35:17 +0200")
>> That was my initial thought as well, but when I tried to implement it,
>> it quickly turned into a scavenge hunt trying to find all the places
>> where it needs to be set (and re-set after a kill-all-local-variables).
> That's strange: don't we have a single place where we create the
> minibuffer?
Yes, but the problem is that we reuse the minibuffers and that we need
to re-set the var after killing local vars, so the only sane place to
change this would be in `reset_buffer_local_variables`.
>> How 'bout the patch below, then?
> LGTM, modulo the NEWS and ELisp manual updates.
OK, thanks. Done and pushed.
>> + DEFVAR_BOOL ("minibuffer-scroll-conservatively",
>> + minibuffer_scroll_conservatively,
>> + doc: /* Non-nil means scroll conservatively in minibuffer windows.
>> +When the value is nil, scrolling in minibuffer windows obeys the
>> +settings of `scroll-conservatively'. */);
>
> I'd say "behaves as if scroll-conservatively were set" instead of
> "obeys the setting of scroll-conservatively", because the latter can
> be interpreted as meaning one actually needs to set
> scroll-conservatively.
That's indeed what it means since it describes the behavior when the var
is nil (which is the old behavior).
Stefan
next prev parent reply other threads:[~2020-10-31 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 22:09 bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Stefan Monnier
2020-10-19 16:34 ` Eli Zaretskii
2020-10-29 17:54 ` Stefan Monnier
2020-10-31 8:35 ` Eli Zaretskii
2020-10-31 13:12 ` Stefan Monnier [this message]
2020-10-31 18:40 ` Eli Zaretskii
2020-11-01 13:29 ` Stefan Monnier
2020-11-01 14:12 ` Stefan Monnier
2020-11-01 15:38 ` Eli Zaretskii
2020-11-01 18:59 ` Stefan Monnier
2020-11-01 19:36 ` Eli Zaretskii
2020-11-01 19:54 ` Stefan Monnier
2020-11-01 15:32 ` Eli Zaretskii
2020-11-01 15:38 ` Stefan Monnier
2020-11-01 15:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsg9u7dcb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=44070@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).