From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sat, 31 Oct 2020 09:12:16 -0400 Message-ID: References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38752"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44070@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 31 14:13:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYqgu-0009yg-PT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 14:13:08 +0100 Original-Received: from localhost ([::1]:48062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYqgt-0003Ww-OF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 09:13:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYqgo-0003Wl-4n for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49124) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYqgn-0005p6-QK for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 09:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYqgn-0004iq-KZ for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 09:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.160414994618108 (code B ref 44070); Sat, 31 Oct 2020 13:13:01 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 31 Oct 2020 13:12:26 +0000 Original-Received: from localhost ([127.0.0.1]:60669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYqgE-0004hz-I1 for submit@debbugs.gnu.org; Sat, 31 Oct 2020 09:12:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYqgC-0004hi-GB for 44070@debbugs.gnu.org; Sat, 31 Oct 2020 09:12:25 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 46E7744079E; Sat, 31 Oct 2020 09:12:19 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EFFFC440768; Sat, 31 Oct 2020 09:12:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604149937; bh=EaoLAr9tXfHu/JXrn3RBovMc0n9rCb5rcmusJYjdx+E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lngZy0kdvVHWF7dx0LL/TfAXm/OrR9w5mzYkGPCAe5doEFqcr2g9FAmEWTNdMYSm/ uH+Av2EzmJ1HF6wZD69Wxfi36x7LPHG3QwOCg9H59mgb9qC569caIJvKKgPSQbWl6V 9kz7FapsmBg6MyQ/QgtaLssWohWfOViUleGUSspxOAafUCUS8Ix3MAI2M5ca3MrDnt 1GLbh0yHSmpSkbI23Ko2q2WLxWJ2fskRJ29+8dcfsfx8vP7rjFPzPmChMGDMa/7A9q 80sdvwq7czNBpmpJdtMfc49qMkkrMwVCfmEydoz/K/Rv1/pOzLqltnvp/KizqEJoas gM3CZgrTRusbA== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF089120257; Sat, 31 Oct 2020 09:12:17 -0400 (EDT) In-Reply-To: <83sg9uhjy2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Oct 2020 10:35:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192266 Archived-At: >> That was my initial thought as well, but when I tried to implement it, >> it quickly turned into a scavenge hunt trying to find all the places >> where it needs to be set (and re-set after a kill-all-local-variables). > That's strange: don't we have a single place where we create the > minibuffer? Yes, but the problem is that we reuse the minibuffers and that we need to re-set the var after killing local vars, so the only sane place to change this would be in `reset_buffer_local_variables`. >> How 'bout the patch below, then? > LGTM, modulo the NEWS and ELisp manual updates. OK, thanks. Done and pushed. >> + DEFVAR_BOOL ("minibuffer-scroll-conservatively", >> + minibuffer_scroll_conservatively, >> + doc: /* Non-nil means scroll conservatively in minibuffer windows. >> +When the value is nil, scrolling in minibuffer windows obeys the >> +settings of `scroll-conservatively'. */); > > I'd say "behaves as if scroll-conservatively were set" instead of > "obeys the setting of scroll-conservatively", because the latter can > be interpreted as meaning one actually needs to set > scroll-conservatively. That's indeed what it means since it describes the behavior when the var is nil (which is the old behavior). Stefan