From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 44070@debbugs.gnu.org
Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit
Date: Sun, 01 Nov 2020 14:54:11 -0500 [thread overview]
Message-ID: <jwvsg9szx01.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83sg9seunn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Nov 2020 21:36:44 +0200")
>> >> Also, I'm not sure that's what we want to do: as I argued in my previous
>> >> message, this change is mostly meant to better fit the behavior of
>> >> resize_mini_window, and that behavior applies to all mini-windows,
>> >> regardless if they're used for a minibuffer or something else.
>> > My line of thinking was that, while in minibuffers we usually want to
>> > see the end of the text, that is not necessarily true in echo-area
>> > messages.
>> Yet, that's what `resize_mini_window` does for all mini-windows
>> regardless of it's an echo-area or not.
> Resizing is one thing; which part of partially displayed text to show
> is another. They aren't the same decisions.
Right, but `resize_mini_window` does do both: it resizes the window and
and sets the window-start according to its rules of which part should
be displayed. My patch tries to make the non-resizing scrolls
follow the same logic as that of `resize_mini_window` to
avoid inconsistencies.
>> Also, my patch shouldn't affect whether we "see the end of the text", so
>> maybe I just don't understand what you're referring to.
> Where do you think point is in an echo-area buffer?
I must say that I don't know, but I expect it should be either at BOB or
at EOB: if it's a BOB then my patch won't make any difference because
`window-start` will be set to BOB regardless of the scroll being
conservative or not; if it's at EOB my patch will maximize the amount of
text actually displayed, which is also what `resize_mini_window` does,
but I suspect that for each-areas this won't make any difference because
I've never seen an echo-area messages "scrolled" such that there's white
space left below its end (probably because `resize_mini_window` already
did the job, so there's no scrolling involved).
>> I thought the test of `scroll_minibuffer_conservative` played this role.
> That's exactly why we need a FIXME: the variable says "minibuffer",
> but the code checks for mini-window.
I chose the word "minibuffer" because it seems those "mini windows" are
usually referred to as "minibuffer windows" in places like
`window-minibuffer-p`. The docstring similarly uses "minibuffer
windows" to refer to those *windows* rather than to their specific use
for minibuffers as opposed to echo area messages, although I strongly
suspect that the variable has indeed no concrete effect in echo-areas.
Stefan
next prev parent reply other threads:[~2020-11-01 19:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 22:09 bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Stefan Monnier
2020-10-19 16:34 ` Eli Zaretskii
2020-10-29 17:54 ` Stefan Monnier
2020-10-31 8:35 ` Eli Zaretskii
2020-10-31 13:12 ` Stefan Monnier
2020-10-31 18:40 ` Eli Zaretskii
2020-11-01 13:29 ` Stefan Monnier
2020-11-01 14:12 ` Stefan Monnier
2020-11-01 15:38 ` Eli Zaretskii
2020-11-01 18:59 ` Stefan Monnier
2020-11-01 19:36 ` Eli Zaretskii
2020-11-01 19:54 ` Stefan Monnier [this message]
2020-11-01 15:32 ` Eli Zaretskii
2020-11-01 15:38 ` Stefan Monnier
2020-11-01 15:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsg9szx01.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=44070@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).