From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44070: 28.0.50; Minibuffer display "jumps" upon minor edit Date: Sun, 01 Nov 2020 14:54:11 -0500 Message-ID: References: <83a6wip43q.fsf@gnu.org> <83sg9uhjy2.fsf@gnu.org> <835z6qgrwt.fsf@gnu.org> <83mu01f5o8.fsf@gnu.org> <83sg9seunn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40221"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44070@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 20:55:26 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZJRl-000ALy-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 20:55:25 +0100 Original-Received: from localhost ([::1]:53018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZJRk-0005x0-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 14:55:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZJRO-0005wb-8q for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZJRN-0005oR-Vz for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZJRN-0002L6-W7 for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 14:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44070 X-GNU-PR-Package: emacs Original-Received: via spool by 44070-submit@debbugs.gnu.org id=B44070.16042604618941 (code B ref 44070); Sun, 01 Nov 2020 19:55:01 +0000 Original-Received: (at 44070) by debbugs.gnu.org; 1 Nov 2020 19:54:21 +0000 Original-Received: from localhost ([127.0.0.1]:38643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJQi-0002K9-U1 for submit@debbugs.gnu.org; Sun, 01 Nov 2020 14:54:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZJQh-0002Ju-M9 for 44070@debbugs.gnu.org; Sun, 01 Nov 2020 14:54:20 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3E442100267; Sun, 1 Nov 2020 14:54:14 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CEED61001CB; Sun, 1 Nov 2020 14:54:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604260452; bh=7lp9sqoApgHYOu69g7FT1bvrMODHB4oKBrZp0trHQqM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IjTBaJs0gvZW2OXnUIK0DvsqZl1D3GnMfVyUDDCyT5wsK96rE2t/9n/xImfKih8wp X9BY1g5agoHGrJI+kwCdE3mprC1lazfyjKETSKcV7NPajbT1svzH3sfVKXhDVcxDK1 rxENAMFIeTXDMV0Apxk8iq6fCiSNiWcQVu9IBqUCRt/Hh6Xj4jEcSVjY19+aw4oKS6 aaFgsQE641zBwXs6uynhvN3+aaVAx4ZwFL44A/9FKcJWjfXMzvOz60jPTVC37j6oCc WQIXgssAjVSbVgl686pfoc3v0KGyKUpO0xuN+cay8BpMLaVqAm1UjCKte8wjrR/e7J FP5rxX9XiWCSQ== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 970601202EE; Sun, 1 Nov 2020 14:54:12 -0500 (EST) In-Reply-To: <83sg9seunn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Nov 2020 21:36:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192457 Archived-At: >> >> Also, I'm not sure that's what we want to do: as I argued in my previous >> >> message, this change is mostly meant to better fit the behavior of >> >> resize_mini_window, and that behavior applies to all mini-windows, >> >> regardless if they're used for a minibuffer or something else. >> > My line of thinking was that, while in minibuffers we usually want to >> > see the end of the text, that is not necessarily true in echo-area >> > messages. >> Yet, that's what `resize_mini_window` does for all mini-windows >> regardless of it's an echo-area or not. > Resizing is one thing; which part of partially displayed text to show > is another. They aren't the same decisions. Right, but `resize_mini_window` does do both: it resizes the window and and sets the window-start according to its rules of which part should be displayed. My patch tries to make the non-resizing scrolls follow the same logic as that of `resize_mini_window` to avoid inconsistencies. >> Also, my patch shouldn't affect whether we "see the end of the text", so >> maybe I just don't understand what you're referring to. > Where do you think point is in an echo-area buffer? I must say that I don't know, but I expect it should be either at BOB or at EOB: if it's a BOB then my patch won't make any difference because `window-start` will be set to BOB regardless of the scroll being conservative or not; if it's at EOB my patch will maximize the amount of text actually displayed, which is also what `resize_mini_window` does, but I suspect that for each-areas this won't make any difference because I've never seen an echo-area messages "scrolled" such that there's white space left below its end (probably because `resize_mini_window` already did the job, so there's no scrolling involved). >> I thought the test of `scroll_minibuffer_conservative` played this role. > That's exactly why we need a FIXME: the variable says "minibuffer", > but the code checks for mini-window. I chose the word "minibuffer" because it seems those "mini windows" are usually referred to as "minibuffer windows" in places like `window-minibuffer-p`. The docstring similarly uses "minibuffer windows" to refer to those *windows* rather than to their specific use for minibuffers as opposed to echo area messages, although I strongly suspect that the variable has indeed no concrete effect in echo-areas. Stefan