From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46243@debbugs.gnu.org
Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo
Date: Thu, 04 Feb 2021 11:50:14 -0500 [thread overview]
Message-ID: <jwvpn1fbx2z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83lfc3rfvp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Feb 2021 17:50:50 +0200")
> I took a look at the related code, including the changes in Emacs 23
> that caused bug#15332, but didn't see any clear suspects. Which may
> not be surprising, as the complex system of variables and flags we use
> in keyboard.c to DTRT with this stuff is above my pay grade.
I think it's above everyone's pay grade, indeed :-(
> So I propose the much simpler patch below. It may look like a kludgey
> band-aid at first sight, but OTOH consider this:
Looks OK to me. It's fairly unusual to want echo-keystrokes working
when there's a prompt in any case. The only case I can think of right
now is for `C-h k` and `C-h c` (but these use `read-key-sequence` so
I think they won't be affected).
Stefan
next prev parent reply other threads:[~2021-02-04 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 18:50 bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Drew Adams
2021-02-01 19:06 ` Drew Adams
2021-02-01 19:33 ` Eli Zaretskii
2021-02-01 22:30 ` bug#46243: [External] : " Drew Adams
2021-02-02 17:04 ` Eli Zaretskii
2021-02-03 15:56 ` Eli Zaretskii
2021-02-03 16:16 ` Stefan Monnier
2021-02-03 17:15 ` Eli Zaretskii
2021-02-03 17:42 ` Stefan Monnier
2021-02-03 19:56 ` Stefan Monnier
2021-02-04 15:50 ` Eli Zaretskii
2021-02-04 16:50 ` Stefan Monnier [this message]
2021-02-04 17:37 ` Eli Zaretskii
2021-02-04 19:23 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpn1fbx2z.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46243@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).