From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Date: Thu, 04 Feb 2021 11:50:14 -0500 Message-ID: References: <83r1lz60so.fsf@gnu.org> <83a6sm5rlr.fsf@gnu.org> <83pn1h401u.fsf@gnu.org> <83k0rp3wew.fsf@gnu.org> <83lfc3rfvp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39321"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46243@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 04 18:58:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7itJ-000A50-77 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 18:58:05 +0100 Original-Received: from localhost ([::1]:59250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7itI-0007BW-8q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 12:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7hqQ-0004t0-4R for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 11:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7hqP-0001Gw-T1 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 11:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7hqP-0000Yi-PY for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 11:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2021 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46243 X-GNU-PR-Package: emacs Original-Received: via spool by 46243-submit@debbugs.gnu.org id=B46243.16124574242104 (code B ref 46243); Thu, 04 Feb 2021 16:51:01 +0000 Original-Received: (at 46243) by debbugs.gnu.org; 4 Feb 2021 16:50:24 +0000 Original-Received: from localhost ([127.0.0.1]:42128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7hpo-0000Xs-DY for submit@debbugs.gnu.org; Thu, 04 Feb 2021 11:50:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7hpm-0000Xe-Cq for 46243@debbugs.gnu.org; Thu, 04 Feb 2021 11:50:23 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 08DBB809A7; Thu, 4 Feb 2021 11:50:17 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6C6F9807E9; Thu, 4 Feb 2021 11:50:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612457415; bh=kZ07nRfwbxPP+3N3ntZrFKPA8JwE13AlWg/DQ4kUQLQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oJI9IC7QycSuwM09aEakhU4aZGGE80prTeUefS4yGiCsK/QDPBOIjrt37WE78vlnN w9rRCiY4NXdwZTg3qtu6Rm5j5o/iR2OewOQ03Ec6mxa/BRwdueg0+Ppqtl/EeSJ6dZ 4pNOKYLwsf3n387Xut/VOUXTdDXnue0N0Q7h4km2ImP4uagKMhJLs70XBgLZG5c4/Y tKub8uSxAFDB2JZL7n/uhHgl8FtDFXFWa50MDD/IFMm+grzxSh4GSPJZX3EScgPCvH 6KaJvQnzeTmMLAAYMoT2hFs5pap9mZdffT5MxKANbfGWrA41rImV373f2tpL6ryvJN 7eH9JF+UniGCw== Original-Received: from alfajor (76-10-182-85.dsl.teksavvy.com [76.10.182.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3158B1204F6; Thu, 4 Feb 2021 11:50:15 -0500 (EST) In-Reply-To: <83lfc3rfvp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Feb 2021 17:50:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199314 Archived-At: > I took a look at the related code, including the changes in Emacs 23 > that caused bug#15332, but didn't see any clear suspects. Which may > not be surprising, as the complex system of variables and flags we use > in keyboard.c to DTRT with this stuff is above my pay grade. I think it's above everyone's pay grade, indeed :-( > So I propose the much simpler patch below. It may look like a kludgey > band-aid at first sight, but OTOH consider this: Looks OK to me. It's fairly unusual to want echo-keystrokes working when there's a prompt in any case. The only case I can think of right now is for `C-h k` and `C-h c` (but these use `read-key-sequence` so I think they won't be affected). Stefan