unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "46243@debbugs.gnu.org" <46243@debbugs.gnu.org>
Subject: bug#46243: [External] : Re: bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo
Date: Mon, 1 Feb 2021 22:30:54 +0000	[thread overview]
Message-ID: <SA2PR10MB44740C484A718A3AB95B67E5F3B69@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <83r1lz60so.fsf@gnu.org>

> > If I have a menu item that reads a character, the
> > prompt for that read is not seen; the menu selection
> > key sequence gets echoed instead.  This shouldn't
> > happen (should it?).
> 
> I think it should, but I couldn't verify that, because
> your recipes didn't work for me.  Please provide a
> recipe that would work in "emacs -Q".

emacs -Q            ; e.g. Emacs 27.1

(defun diredp-mark-with-char (char &optional arg)
  "Mark this line with CHAR.
With numeric prefix arg N, mark the next N lines."
  (interactive
   (progn (message nil)
	  (list (read-char "Mark this line with char: ")
		(prefix-numeric-value current-prefix-arg))))
  (let ((dired-marker-char  char))
    (dired-mark arg)))

(define-key dired-mode-map [menu-bar mark with-char]
  '(menu-item
     "Mark This with Char..." diredp-mark-with-char
     :help "Mark this line with a character you type"))

Now try the same thing but with (message nil) commented out.

With (message nil), you see the prompt:

   Mark this line with char:

Without (message nil), you see only this:

   menu-bar mark with-char-

The command works OK, but a user will have no clue
about typing a char.

Clear enough?  The change was introduced in Emacs 24,
AFAICT.  Regression or improvement?  Am I missing
something?

(You can forget about easy-menu for this bug report,
at least for now, please.)





  reply	other threads:[~2021-02-01 22:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 18:50 bug#46243: 26.3; If invoke menu item that reads a char, get keystrokes echo Drew Adams
2021-02-01 19:06 ` Drew Adams
2021-02-01 19:33 ` Eli Zaretskii
2021-02-01 22:30   ` Drew Adams [this message]
2021-02-02 17:04     ` bug#46243: [External] : " Eli Zaretskii
2021-02-03 15:56       ` Eli Zaretskii
2021-02-03 16:16         ` Stefan Monnier
2021-02-03 17:15           ` Eli Zaretskii
2021-02-03 17:42             ` Stefan Monnier
2021-02-03 19:56               ` Stefan Monnier
2021-02-04 15:50               ` Eli Zaretskii
2021-02-04 16:50                 ` Stefan Monnier
2021-02-04 17:37                   ` Eli Zaretskii
2021-02-04 19:23                     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA2PR10MB44740C484A718A3AB95B67E5F3B69@SA2PR10MB4474.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=46243@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).