From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nathan Trapuzzano <nbtrap@nbtrap.com>
Cc: 15814@debbugs.gnu.org
Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch)
Date: Tue, 05 Nov 2013 19:46:45 -0500 [thread overview]
Message-ID: <jwvob5ycqb6.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87k3gmmvk9.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Tue, 05 Nov 2013 15:40:22 -0500")
> --- a/lisp/emacs-lisp/cl-macs.el
> +++ b/lisp/emacs-lisp/cl-macs.el
> @@ -1988,6 +1988,8 @@ by EXPANSION, and (setq NAME ...) will act like (setf EXPANSION ...).
> (cl-symbol-macrolet ,(cdr bindings) ,@body)))
> ((null bindings) (macroexp-progn body))
> (t
> + (cl-assert (and (cdar bindings) (null (cl-cddar bindings))) nil
> + "Malformed `cl-symbol-macrolet' binding: %S" (car bindings))
> (let ((previous-macroexpand (symbol-function 'macroexpand)))
> (unwind-protect
> (progn
Good idea. Could you try and use macroexp--warn-and-return instead, so
we get a file&line location when byte-compiling?
BTW, the same holds for the "let" sanity checks you added to cconv
(which should probably be moved to macroexp, now that I think about it,
so we can remove them from bytecomp.el).
Stefan
next prev parent reply other threads:[~2013-11-06 0:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:40 bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Nathan Trapuzzano
2013-11-06 0:46 ` Stefan Monnier [this message]
2013-11-06 2:19 ` Nathan Trapuzzano
2013-11-06 3:20 ` Stefan Monnier
2013-11-06 11:16 ` Nathan Trapuzzano
2013-11-06 13:45 ` Stefan Monnier
2013-11-07 1:14 ` Nathan Trapuzzano
2013-11-07 2:08 ` Stefan Monnier
2013-11-07 3:22 ` Nathan Trapuzzano
2013-11-07 4:38 ` Stefan Monnier
2013-11-07 19:51 ` Nathan Trapuzzano
2013-11-08 1:21 ` Stefan Monnier
2013-11-08 1:29 ` Nathan Trapuzzano
2013-11-08 3:02 ` Stefan Monnier
2013-11-08 11:40 ` Nathan Trapuzzano
2013-11-08 13:33 ` Stefan Monnier
2013-11-08 14:39 ` Nathan Trapuzzano
2013-11-08 19:06 ` Stefan Monnier
2013-11-09 2:06 ` Nathan Trapuzzano
2013-11-09 8:36 ` Andreas Schwab
2013-11-09 12:00 ` Nathan Trapuzzano
2013-11-11 4:55 ` Stefan Monnier
2013-11-07 7:08 ` bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch Paul Eggert
2013-11-07 12:58 ` Nathan Trapuzzano
2013-11-07 19:46 ` Stefan Monnier
2013-11-07 21:03 ` Glenn Morris
2013-11-07 22:07 ` Glenn Morris
2013-11-08 1:34 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob5ycqb6.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15814@debbugs.gnu.org \
--cc=nbtrap@nbtrap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).