From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nathan Trapuzzano <nbtrap@nbtrap.com>
Cc: 15814@debbugs.gnu.org
Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch)
Date: Wed, 06 Nov 2013 08:45:24 -0500 [thread overview]
Message-ID: <jwvy551abr5.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87ppqd2314.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Wed, 06 Nov 2013 06:16:55 -0500")
>>> (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S"
>>> (car bindings))))
>>> (macroexp--warn-and-return msg `(error "%s" ,msg)))
>> Signaling an error stops the whole compilation, so you only get one
>> error at a time. Better make it a warning, even though it is indeed
>> a programming error.
> And then signal the error at run time? Do I understand you correctly
> about that?
Check other uses of macroexp--warn-and-return (there aren't many).
It doesn't signal any error at all. But they do emit warnings either
during compilation or while loading an interpreted file.
>> No, I mean that they should be performed in macroexp--expand-all rather
>> than in cconv, so they're performed regardless of lexical-binding
>> (currently they're done once in cconv.el and once in bytecomp.el).
> This wouldn't work since there's no guarantee that any particular form
> passes through macroexp--expand-all, not in the interpreter at least.
As I said, currently it's performed in bytecomp.el and cconv.el, and
there's no way to get to either of those two without going through
macroexp--expand-all first. So, yes, there is a guarantee.
When loading an interpreted file, we go through macroexp--expand-all as
well (not not through cconv.el nor through bytecomp.el).
Stefan
next prev parent reply other threads:[~2013-11-06 13:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:40 bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Nathan Trapuzzano
2013-11-06 0:46 ` Stefan Monnier
2013-11-06 2:19 ` Nathan Trapuzzano
2013-11-06 3:20 ` Stefan Monnier
2013-11-06 11:16 ` Nathan Trapuzzano
2013-11-06 13:45 ` Stefan Monnier [this message]
2013-11-07 1:14 ` Nathan Trapuzzano
2013-11-07 2:08 ` Stefan Monnier
2013-11-07 3:22 ` Nathan Trapuzzano
2013-11-07 4:38 ` Stefan Monnier
2013-11-07 19:51 ` Nathan Trapuzzano
2013-11-08 1:21 ` Stefan Monnier
2013-11-08 1:29 ` Nathan Trapuzzano
2013-11-08 3:02 ` Stefan Monnier
2013-11-08 11:40 ` Nathan Trapuzzano
2013-11-08 13:33 ` Stefan Monnier
2013-11-08 14:39 ` Nathan Trapuzzano
2013-11-08 19:06 ` Stefan Monnier
2013-11-09 2:06 ` Nathan Trapuzzano
2013-11-09 8:36 ` Andreas Schwab
2013-11-09 12:00 ` Nathan Trapuzzano
2013-11-11 4:55 ` Stefan Monnier
2013-11-07 7:08 ` bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch Paul Eggert
2013-11-07 12:58 ` Nathan Trapuzzano
2013-11-07 19:46 ` Stefan Monnier
2013-11-07 21:03 ` Glenn Morris
2013-11-07 22:07 ` Glenn Morris
2013-11-08 1:34 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy551abr5.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15814@debbugs.gnu.org \
--cc=nbtrap@nbtrap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).