From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Date: Tue, 05 Nov 2013 19:46:45 -0500 Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383698840 27819 80.91.229.3 (6 Nov 2013 00:47:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Nov 2013 00:47:20 +0000 (UTC) Cc: 15814@debbugs.gnu.org To: Nathan Trapuzzano Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 01:47:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VdrHH-0002as-8a for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2013 01:47:23 +0100 Original-Received: from localhost ([::1]:59225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdrHG-0004OP-Lf for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Nov 2013 19:47:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdrH6-0004Ny-Tm for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 19:47:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdrGw-0005uw-3X for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 19:47:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdrGw-0005us-0D for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 19:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VdrGv-0002rr-KV for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 19:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2013 00:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15814-submit@debbugs.gnu.org id=B15814.138369881411005 (code B ref 15814); Wed, 06 Nov 2013 00:47:01 +0000 Original-Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 00:46:54 +0000 Original-Received: from localhost ([127.0.0.1]:36369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrGn-0002rQ-MY for submit@debbugs.gnu.org; Tue, 05 Nov 2013 19:46:53 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52959) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrGl-0002rC-Ic for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 19:46:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCSxH5AOkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCSxH5AOkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37179989" Original-Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Nov 2013 19:46:45 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 290FB60A07; Tue, 5 Nov 2013 19:46:45 -0500 (EST) In-Reply-To: <87k3gmmvk9.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Tue, 05 Nov 2013 15:40:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80049 Archived-At: > --- a/lisp/emacs-lisp/cl-macs.el > +++ b/lisp/emacs-lisp/cl-macs.el > @@ -1988,6 +1988,8 @@ by EXPANSION, and (setq NAME ...) will act like (setf EXPANSION ...). > (cl-symbol-macrolet ,(cdr bindings) ,@body))) > ((null bindings) (macroexp-progn body)) > (t > + (cl-assert (and (cdar bindings) (null (cl-cddar bindings))) nil > + "Malformed `cl-symbol-macrolet' binding: %S" (car bindings)) > (let ((previous-macroexpand (symbol-function 'macroexpand))) > (unwind-protect > (progn Good idea. Could you try and use macroexp--warn-and-return instead, so we get a file&line location when byte-compiling? BTW, the same holds for the "let" sanity checks you added to cconv (which should probably be moved to macroexp, now that I think about it, so we can remove them from bytecomp.el). Stefan