From: Stefan Monnier <monnier@iro.umontreal.ca>
To: npostavs@users.sourceforge.net
Cc: 25088@debbugs.gnu.org
Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails
Date: Fri, 09 Dec 2016 11:27:29 -0500 [thread overview]
Message-ID: <jwvoa0lyuya.fsf-monnier+bug#25088@gnu.org> (raw)
In-Reply-To: <87y3zwfxjn.fsf@users.sourceforge.net> (npostavs's message of "Sat, 03 Dec 2016 17:38:36 -0500")
> I think it's safe, but I've been wrong before.
I also think it's safe, and I've also been wrong before.
Another thing: the patch makes sense regardless of the change, since
it's good to define the things before we use them.
> Not sure how much safer this is, I think we would have to record the
> which symbol plists are being modified during `load' so that
> `unload-feature' could find them in `load-history' and reverse them
> along with functions definitions. This would get rid of the
> compiler-macro entries that were added to cl-defstruct accessor function
> symbols, and so they would load successfully the second time round just
> like the first (presumably).
Yes, that would be good. Currently unload-feature automatically un-does
defalias and defvar, more or less, but it would be good to extend this
to other top-level operations like `put`.
Stefan
prev parent reply other threads:[~2016-12-09 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 5:24 bug#25088: 25.1; feature-unload and reload of cl-defstruct fails npostavs
2016-12-02 8:13 ` Eli Zaretskii
2016-12-03 22:38 ` npostavs
2016-12-04 3:35 ` Eli Zaretskii
2016-12-09 5:08 ` npostavs
2016-12-09 8:22 ` Eli Zaretskii
2016-12-09 23:33 ` Dmitry Gutov
2016-12-10 7:18 ` Eli Zaretskii
2016-12-10 9:49 ` Dmitry Gutov
2016-12-10 21:05 ` npostavs
2016-12-09 16:27 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jwvoa0lyuya.fsf-monnier+bug#25088@gnu.org' \
--to=monnier@iro.umontreal.ca \
--cc=25088@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).