From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails Date: Fri, 09 Dec 2016 11:27:29 -0500 Message-ID: References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481300901 20215 195.159.176.226 (9 Dec 2016 16:28:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Dec 2016 16:28:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 25088@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 09 17:28:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFO1t-0003yN-Bd for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2016 17:28:13 +0100 Original-Received: from localhost ([::1]:47535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFO1x-0004Gn-FM for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2016 11:28:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFO1n-0004Ag-O0 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 11:28:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFO1i-0006Qz-MJ for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 11:28:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFO1i-0006Qn-Jn for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 11:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cFO1i-0006BM-9x for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 11:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2016 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25088-submit@debbugs.gnu.org id=B25088.148130086323738 (code B ref 25088); Fri, 09 Dec 2016 16:28:02 +0000 Original-Received: (at 25088) by debbugs.gnu.org; 9 Dec 2016 16:27:43 +0000 Original-Received: from localhost ([127.0.0.1]:36196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFO1P-0006Ao-1P for submit@debbugs.gnu.org; Fri, 09 Dec 2016 11:27:43 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFO1M-0006AZ-C3 for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 11:27:41 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AFKQAu3EVY/xnsSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDYkeCK0Ui0QBAQEBBgIBJIsZhRSFFQWPfIpqmxqGOpIPJgcpeBMOg1wcgXsgiS0BAQE X-IPAS-Result: A0AFKQAu3EVY/xnsSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDYkeCK0Ui0QBAQEBBgIBJIsZhRSFFQWPfIpqmxqGOpIPJgcpeBMOg1wcgXsgiS0BAQE X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="282088025" Original-Received: from 45-72-236-25.cpe.teksavvy.com (HELO pastel.home) ([45.72.236.25]) by smtp.teksavvy.com with ESMTP; 09 Dec 2016 11:27:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3DC6D6554A; Fri, 9 Dec 2016 11:27:29 -0500 (EST) In-Reply-To: <87y3zwfxjn.fsf@users.sourceforge.net> (npostavs's message of "Sat, 03 Dec 2016 17:38:36 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126772 Archived-At: > I think it's safe, but I've been wrong before. I also think it's safe, and I've also been wrong before. Another thing: the patch makes sense regardless of the change, since it's good to define the things before we use them. > Not sure how much safer this is, I think we would have to record the > which symbol plists are being modified during `load' so that > `unload-feature' could find them in `load-history' and reverse them > along with functions definitions. This would get rid of the > compiler-macro entries that were added to cl-defstruct accessor function > symbols, and so they would load successfully the second time round just > like the first (presumably). Yes, that would be good. Currently unload-feature automatically un-does defalias and defvar, more or less, but it would be good to extend this to other top-level operations like `put`. Stefan