From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25088@debbugs.gnu.org
Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails
Date: Sat, 03 Dec 2016 17:38:36 -0500 [thread overview]
Message-ID: <87y3zwfxjn.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83eg1qoiiv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Dec 2016 10:13:44 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>
> How risky is this change? cl-defstruct is a very widely used macro,
> whereas unload-feature is a relatively obscure feature. Is it really
> worth fixing the (IMO minor) error and risking to break Emacs 25.2?
>
> I don't have an intuition I can trust in these matters, so I need you
> and others who do to offer their opinions, after carefully considering
> the pros and cons.
I think it's safe, but I've been wrong before. I agree that
unload-feature is sufficiently obscure that this can go to master
instead of emacs-25.
Perhaps the real bug is that unload-feature doesn't undo `put', thus the
compiler-macro still hangs around.
next prev parent reply other threads:[~2016-12-03 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 5:24 bug#25088: 25.1; feature-unload and reload of cl-defstruct fails npostavs
2016-12-02 8:13 ` Eli Zaretskii
2016-12-03 22:38 ` npostavs [this message]
2016-12-04 3:35 ` Eli Zaretskii
2016-12-09 5:08 ` npostavs
2016-12-09 8:22 ` Eli Zaretskii
2016-12-09 23:33 ` Dmitry Gutov
2016-12-10 7:18 ` Eli Zaretskii
2016-12-10 9:49 ` Dmitry Gutov
2016-12-10 21:05 ` npostavs
2016-12-09 16:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3zwfxjn.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25088@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).