unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Xingyu Pu <pu.stshine@gmail.com>,
	53805@debbugs.gnu.org
Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies
Date: Sun, 06 Feb 2022 09:57:27 -0500	[thread overview]
Message-ID: <jwvo83k59r4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a6f4ieue.fsf@posteo.net> (Thierry Volpiatto's message of "Sun,  06 Feb 2022 08:22:49 +0000")

>> The best course of action is to fix the upstream.
>> They simply shouldn't have any `<foo>-pkg.el` file.
> I disagree, in the simple case of async package this didn't cause problems, but
> here it does because we have two packages (helm-core+helm) coming from
> the same git repo.

I don't see in which way it makes a difference.
For the `helm-core` package, the info will be fetched from the headers
of `helm-core.el`.

>> We will generate the `<foo>-pkg.el` in any case because we include more
>> information there than what the upstream will have put (e.g. we include
>> the commit id from which the tarball is built),
> So what is the problem?

The problem is not fundamental, but since the scripts we have generate
the `<pkg>-pkg.el` file in place, it means we end up with a dirty Git
clone where some of the tracked files have been locally modified, so
later operations like `merge` can get spurious conflicts.

The scripts try to handle those problems by cleaning after themselves,
but apparently not well enough because I've already had to go and
manually unwedge the system for a few packages that have their own
`<pkg>-pkg.el` file (`helm` and `helm-core` being among those I've had
to manually unwedge :-( ).

>> and and modifying files that are under version control tends to lead
>> to problems.
> You are anyway creating a new *pkg.el file so why do you want to modify
> the original *pkg.el files?

Since it works in place, there is no difference between "creating a new
*pkg.el file" and "modify the original *pkg.el files".


        Stefan






  parent reply	other threads:[~2022-02-06 14:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 14:52 bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Xingyu Pu
2022-02-05 19:08 ` Philip Kaludercic
2022-02-05 22:16   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-05 22:29     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06  8:22     ` Thierry Volpiatto
2022-02-06 10:12       ` Philip Kaludercic
2022-02-06 14:57       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-02-06 16:07         ` Thierry Volpiatto
2022-02-06 16:26           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06 17:57             ` Thierry Volpiatto
2022-02-06 19:19               ` Xingyu Pu
2022-02-06 20:40               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 14:16               ` Pu Xingyu
2022-02-10 16:35                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-11 17:49                   ` Pu Xingyu
2022-02-11 18:46                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06 15:52       ` Thierry Volpiatto
2022-02-06 16:21         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvo83k59r4.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=53805@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    --cc=pu.stshine@gmail.com \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).