From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Date: Sun, 06 Feb 2022 09:57:27 -0500 Message-ID: References: <8735kx3zct.fsf@posteo.net> <87a6f4ieue.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philip Kaludercic , Xingyu Pu , 53805@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 15:58:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGizX-0002E6-Hd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 15:58:15 +0100 Original-Received: from localhost ([::1]:51842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGizV-0005Kb-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 09:58:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGizK-0005KT-Bj for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 09:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGizJ-000124-Vs for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 09:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGizK-00022o-01 for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53805 X-GNU-PR-Package: emacs Original-Received: via spool by 53805-submit@debbugs.gnu.org id=B53805.16441594637831 (code B ref 53805); Sun, 06 Feb 2022 14:58:01 +0000 Original-Received: (at 53805) by debbugs.gnu.org; 6 Feb 2022 14:57:43 +0000 Original-Received: from localhost ([127.0.0.1]:39507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGiz1-00022E-Ak for submit@debbugs.gnu.org; Sun, 06 Feb 2022 09:57:43 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGiyz-00021x-4X for 53805@debbugs.gnu.org; Sun, 06 Feb 2022 09:57:42 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D6DC0805D6; Sun, 6 Feb 2022 09:57:34 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 22D9F803D6; Sun, 6 Feb 2022 09:57:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644159449; bh=yP9cWGHfgMLzizmwro4IsEAojdF7cNlO9q6S+fOl/YU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P2EeclZRtujd539SeGcUaWGTUTcuqCHg5+mae+i9t3C5GYaJMW8cEvjtOoV6Qxiit v1tqKo10sFPfjnAzRJVXxi8d4V57mKjGyN3eIV7RM8i/qmu1hWXT0CS16R8J5DcmHe O8UOVg04E5DKXA6A2XyRWckaaHXZoJVwn/bk9I/mIfFbmtMghwYXghi3RoT4acsE8Q tf2TttmeevQAFF2SU+ZzaXRTe57keJBnrov0ozYiOX8MQFl3X2UA4my/ep1XBlVuFt zXaFtRYIsaWeR0Fm9za8Gs/12H45rNGJltAMYbrV4YtcjvioLhxGG7en4932D1tVL1 5iEMiLQntbRyA== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B64211204B7; Sun, 6 Feb 2022 09:57:28 -0500 (EST) In-Reply-To: <87a6f4ieue.fsf@posteo.net> (Thierry Volpiatto's message of "Sun, 06 Feb 2022 08:22:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226154 Archived-At: >> The best course of action is to fix the upstream. >> They simply shouldn't have any `-pkg.el` file. > I disagree, in the simple case of async package this didn't cause problems, but > here it does because we have two packages (helm-core+helm) coming from > the same git repo. I don't see in which way it makes a difference. For the `helm-core` package, the info will be fetched from the headers of `helm-core.el`. >> We will generate the `-pkg.el` in any case because we include more >> information there than what the upstream will have put (e.g. we include >> the commit id from which the tarball is built), > So what is the problem? The problem is not fundamental, but since the scripts we have generate the `-pkg.el` file in place, it means we end up with a dirty Git clone where some of the tracked files have been locally modified, so later operations like `merge` can get spurious conflicts. The scripts try to handle those problems by cleaning after themselves, but apparently not well enough because I've already had to go and manually unwedge the system for a few packages that have their own `-pkg.el` file (`helm` and `helm-core` being among those I've had to manually unwedge :-( ). >> and and modifying files that are under version control tends to lead >> to problems. > You are anyway creating a new *pkg.el file so why do you want to modify > the original *pkg.el files? Since it works in place, there is no difference between "creating a new *pkg.el file" and "modify the original *pkg.el files". Stefan