unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Xingyu Pu <pu.stshine@gmail.com>,
	53805@debbugs.gnu.org
Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies
Date: Sun, 06 Feb 2022 11:21:07 -0500	[thread overview]
Message-ID: <jwvfsow3ruj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sfswj8fw.fsf@posteo.net> (Thierry Volpiatto's message of "Sun,  06 Feb 2022 15:52:13 +0000")

>> What is the issue in this case?  The ELPAs already have packages that
>> share common upstream repositories.  The main issue here that I see is
>> that helm.el and helm-core.el
> There is no helm-core.el file.

Then create one.  It doesn't need to hold anything else than the usual header.
[ Tho, in NonGNU ELPA we work around this currently by telling to use
  `helm.el` instead.  ]

IOW I suggest the patch below (which also fixes some inconsistencies
between the info in `helm.el` and in `helm-pkg.el`).

BTW, is "Development files for Helm" really a good description?
To me it would indicate that it's a package with a similar role to
Debian's <foo>-dev packages, i.e. a package only needed if you're
developing code for Helm, rather than if you merely use the Helm tools.


        Stefan


diff --git a/.gitignore b/.gitignore
index 46bc97419b..e734827684 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,5 +3,8 @@ patch*
 *.patch
 *.diff
 TAGS
-helm-autoloads.el
+/helm-autoloads.el
+/helm-core-autoloads.el
+/helm-pkg.el
+/helm-core-pkg.el
 ID
diff --git a/helm-core-pkg.el b/helm-core-pkg.el
deleted file mode 100644
index 9ea9fbaaaf..0000000000
--- a/helm-core-pkg.el
+++ /dev/null
@@ -1,11 +0,0 @@
-;;; helm-core-pkg.el --- define helm-core for package.el
-
-(define-package "helm-core" "3.8.4"
-  "Development files for Helm"
-  '((emacs "25.1")
-    (async "1.9.4"))
-  :url "https://emacs-helm.github.io/helm/")
-
-;; Local Variables:
-;; no-byte-compile: t
-;; End:
diff --git a/helm-core.el b/helm-core.el
new file mode 100644
index 0000000000..861492eece
--- /dev/null
+++ b/helm-core.el
@@ -0,0 +1,33 @@
+;;; helm-core.el --- Development files for Helm  -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2022  Thierry Volpiatto
+
+;; Author: Thierry Volpiatto <thierry.volpiatto@gmail.com>
+;; URL: https://emacs-helm.github.io/helm/
+;; Version: 3.8.4
+;; Package-Requires: ((emacs "25.1") (async "1.9.4"))
+
+;; This program is free software; you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; This is just a place holder we currently use only to hold the package's
+;; metadata in the header.
+
+;;; Code:
+
+
+
+(provide 'helm-core)
+;;; helm-core.el ends here
diff --git a/helm-pkg.el b/helm-pkg.el
deleted file mode 100644
index 6d0a91c5d5..0000000000
--- a/helm-pkg.el
+++ /dev/null
@@ -1,13 +0,0 @@
-;;; helm-pkg.el --- define helm for package.el
-
-(define-package "helm" "3.8.4"
-  "Helm is an Emacs incremental and narrowing framework"
-  '((emacs "25.1")
-    (async "1.9.4")
-    (popup "0.5.3")
-    (helm-core "3.8.4"))
-  :url "https://emacs-helm.github.io/helm/")
-
-;; Local Variables:
-;; no-byte-compile: t
-;; End:
diff --git a/helm.el b/helm.el
index f54e193344..fbf4637d94 100644
--- a/helm.el
+++ b/helm.el
@@ -1,7 +1,4 @@
-;;; helm.el --- Emacs incremental and narrowing framework -*- lexical-binding: t -*-
-
-;; Version: 3.8.3
-;; URL: https://github.com/emacs-helm/helm
+;;; helm.el --- Helm is an Emacs incremental and narrowing framework  -*- lexical-binding: t -*-
 
 ;; Copyright (C) 2007         Tamas Patrovics
 ;;               2008 ~ 2011  rubikitch <rubikitch@ruby-lang.org>
@@ -14,7 +11,11 @@
 ;;                         Thierry Volpiatto <thierry.volpiatto@gmail.com>
 
 ;; Author: Thierry Volpiatto <thierry.volpiatto@gmail.com>
-;; URL: http://github.com/emacs-helm/helm
+;; Version: 3.8.4
+;; URL: https://emacs-helm.github.io/helm/
+;; FIXME: The `emacs' and `async' requirements are already satisfied by
+;; `helm-core', so maybe we don't need them here?
+;; Package-Requires: ((emacs "25.1") (async "1.9.4") (popup "0.5.3") (helm-core "3.8.4"))
 
 ;; This program is free software; you can redistribute it and/or modify
 ;; it under the terms of the GNU General Public License as published by






      reply	other threads:[~2022-02-06 16:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05 14:52 bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Xingyu Pu
2022-02-05 19:08 ` Philip Kaludercic
2022-02-05 22:16   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-05 22:29     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06  8:22     ` Thierry Volpiatto
2022-02-06 10:12       ` Philip Kaludercic
2022-02-06 14:57       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06 16:07         ` Thierry Volpiatto
2022-02-06 16:26           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06 17:57             ` Thierry Volpiatto
2022-02-06 19:19               ` Xingyu Pu
2022-02-06 20:40               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 14:16               ` Pu Xingyu
2022-02-10 16:35                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-11 17:49                   ` Pu Xingyu
2022-02-11 18:46                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-06 15:52       ` Thierry Volpiatto
2022-02-06 16:21         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfsow3ruj.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=53805@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    --cc=pu.stshine@gmail.com \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).