From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 11301@debbugs.gnu.org, Drew Adams <drew.adams@oracle.com>
Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group
Date: Thu, 03 Jun 2021 09:20:44 -0400 [thread overview]
Message-ID: <jwvfsxz84q7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874kefbdcx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Jun 2021 09:45:34 +0200")
Lars Ingebrigtsen [2021-06-03 09:45:34] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Since the `:group` was only used for the `defcustom`, I just removed
>> this special handling. It doesn't mean it doesn't work any more, but
>> now it's just another one of the keyword args that are simply passed
>> as-is to `defcustom`.
>
> Ah, I see. But it seems like `define-minor-mode' just discards :group
> now. Here's a test case:
The "extra args for decustom" are only used when define-minor-mode uses
a defcustom, i.e. only for global minor modes.
Stefan
next prev parent reply other threads:[~2021-06-03 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 17:18 bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Drew Adams
2012-04-21 17:48 ` Drew Adams
2021-06-02 6:54 ` Lars Ingebrigtsen
2021-06-02 13:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-03 7:45 ` Lars Ingebrigtsen
2021-06-03 13:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-06-04 8:45 ` Lars Ingebrigtsen
2021-06-04 17:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-06 9:29 ` Lars Ingebrigtsen
2021-06-06 17:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfsxz84q7.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=11301@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).