From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 11301@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group
Date: Wed, 02 Jun 2021 08:54:50 +0200 [thread overview]
Message-ID: <87wnrc7o3p.fsf@gnus.org> (raw)
In-Reply-To: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> (Drew Adams's message of "Sat, 21 Apr 2012 10:18:34 -0700")
"Drew Adams" <drew.adams@oracle.com> writes:
> My suggestion is for `define-minor-mode' - and perhaps other
> mode-defining macros - to do likewise. `define-minor-mode' apparently
> uses the :group keyword only for defining the user options it defines.
I've tried following the logic and history of the :group keyword in
easy-mmode.el, and I'm not sure how that's supposed to work any more.
`define-minor-mode' used to document taking a :group keyword, but that's
been removed in:
commit 6e7736ac5f42e2f1b17aacdfb2a60d8bb951d038
Author: Stefan Monnier <monnier@iro.umontreal.ca>
AuthorDate: Wed Sep 9 13:29:59 2020 -0400
The only remaining mention is in this example:
For example, you could write
(define-minor-mode foo-mode \"If enabled, foo on you!\"
:lighter \" Foo\" :require \\='foo :global t :group \\='hassle :version \"27.5\"
...BODY CODE...)
`define-globalized-minor-mode' does mention it, though, and passes it on
to `define-minor-mode'... which doesn't use it?
I've added Stefan to the CCs; I'm sure he knows what's going on.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-06-02 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 17:18 bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Drew Adams
2012-04-21 17:48 ` Drew Adams
2021-06-02 6:54 ` Lars Ingebrigtsen [this message]
2021-06-02 13:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-03 7:45 ` Lars Ingebrigtsen
2021-06-03 13:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-04 8:45 ` Lars Ingebrigtsen
2021-06-04 17:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-06 9:29 ` Lars Ingebrigtsen
2021-06-06 17:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnrc7o3p.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=11301@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).