From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Thu, 03 Jun 2021 09:20:44 -0400 Message-ID: References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> <87wnrc7o3p.fsf@gnus.org> <874kefbdcx.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11301@debbugs.gnu.org, Drew Adams To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 03 15:22:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lonIX-0004F8-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 15:22:09 +0200 Original-Received: from localhost ([::1]:42116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lonIW-0003BY-KG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 09:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lonIQ-0003B9-Ld for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 09:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lonIP-000623-S5 for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 09:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lonIP-0003rQ-O7 for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 09:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11301 X-GNU-PR-Package: emacs Original-Received: via spool by 11301-submit@debbugs.gnu.org id=B11301.162272646114760 (code B ref 11301); Thu, 03 Jun 2021 13:22:01 +0000 Original-Received: (at 11301) by debbugs.gnu.org; 3 Jun 2021 13:21:01 +0000 Original-Received: from localhost ([127.0.0.1]:42886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lonHN-0003pW-Gw for submit@debbugs.gnu.org; Thu, 03 Jun 2021 09:21:01 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lonHI-0003pF-Ay for 11301@debbugs.gnu.org; Thu, 03 Jun 2021 09:20:56 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6D12A4407E7; Thu, 3 Jun 2021 09:20:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 38F85440803; Thu, 3 Jun 2021 09:20:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622726445; bh=MxNXNl3EmaPeAtWF0+84vDSZt9bi8Vq4KKku7e2FBtI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gejoYWiZ5xGgbDqp29aYBIHs3WZvUlswu5XfHNIsA1LUXWQ2S50vCvtnKlBwY+Y0r gbJN2nqe9Bjg5T6RxnDjfT32KhxHdZ6jQueYyims5oZHdTHHBSwjWcEEFPiF1aoNrT OajHMUKVLfeDl0zvf1JyVRsqnxT572wPvsURz63Ch94/6OsYyHjwEAR8gr3Hjm8zaq HsuusIG1J71zhpV1PnZhCGjwQ4RdP5o++EY+/x1/A42V3ojE3IC0lP5MKEBrLexVIK 1ZoY/mupNVmR7YfLiJW3X32sS3I2Qrm+hdVg7VWmpEOnDi/Bk9CmqSvoPFhlRyDlWX TIji+pEeDtekQ== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0853B120151; Thu, 3 Jun 2021 09:20:45 -0400 (EDT) In-Reply-To: <874kefbdcx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Jun 2021 09:45:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207952 Archived-At: Lars Ingebrigtsen [2021-06-03 09:45:34] wrote: > Stefan Monnier writes: >> Since the `:group` was only used for the `defcustom`, I just removed >> this special handling. It doesn't mean it doesn't work any more, but >> now it's just another one of the keyword args that are simply passed >> as-is to `defcustom`. > > Ah, I see. But it seems like `define-minor-mode' just discards :group > now. Here's a test case: The "extra args for decustom" are only used when define-minor-mode uses a defcustom, i.e. only for global minor modes. Stefan