From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 24767@debbugs.gnu.org
Subject: bug#24767: jgraph comments not recognized any more
Date: Tue, 25 Oct 2016 09:52:28 -0400 [thread overview]
Message-ID: <jwva8dsbktv.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <20161024193451.GA4544@acm.fritz.box> (Alan Mackenzie's message of "Mon, 24 Oct 2016 19:34:51 +0000")
> Suppose the jgraph buffer contains:
>
> he(*llo*)
>
> . Is this supposed to analyse as the symbol "he" followed by a comment,
> or should it be the symbol "he(*llo*)"?
Good question. To the extent that src/syntax.c shouldn't be specific to
jgraph-mode, the answer shouldn't depend on the choice made by
Jgraph's author.
> Currently, even Emacs-25 doesn't recognise the "(*llo*)" as a comment.
I think it's good enough to preserve backward compatibility, then.
> It seems to me more likely that the comment should be recognised, but
> I don't know jgraph.
To choose which of the two behavior is desired, the major mode author
can use syntax-propertize to catch this rare corner case anyway.
> Maybe the solution (in master) would be to add the checking of the
> comment flags into this subsidiary loop.
Let's not worry about it.
Stefan
next prev parent reply other threads:[~2016-10-25 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 21:24 bug#24767: jgraph comments not recognized any more Stefan Monnier
2016-10-23 6:17 ` Eli Zaretskii
2016-10-23 15:34 ` Alan Mackenzie
2016-10-24 19:34 ` Alan Mackenzie
2016-10-25 13:52 ` Stefan Monnier [this message]
2016-10-29 11:02 ` Alan Mackenzie
2016-10-29 15:12 ` Stefan Monnier
2016-10-30 17:37 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwva8dsbktv.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=24767@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).