From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 24767@debbugs.gnu.org
Subject: bug#24767: jgraph comments not recognized any more
Date: Sun, 23 Oct 2016 15:34:09 +0000 [thread overview]
Message-ID: <20161023153409.GA23704@acm.fritz.box> (raw)
In-Reply-To: <83bmybpp1s.fsf@gnu.org>
Hello, Eli.
On Sun, Oct 23, 2016 at 09:17:19AM +0300, Eli Zaretskii wrote:
> > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > Date: Sat, 22 Oct 2016 17:24:01 -0400
> >
> > % emacs -Q -l .../elpa/packages/jgraph-mode/jgraph-mode.el ~/foo.jgr
> > (* hello *)
> >
> > The string "(* hello *)" should be highlighted as a comment, and is
> > indeed correctly highlighted this way in Emacs-25 (and Emacs-24), but
> > not in "master".
> >
> > The particularity of jgraph-mode's handling of (*...*) is that ?(, ?),
> > and ?* are given "symbol" syntax, so I guess that src/syntax.c was
> > modified in a way which makes it skip the whole (* as being a symbol.
> I suspect 9dcf599. Alan, could you please take a look?
Yes, 9dcf599 is indeed where the bug was introduced. I'll be looking at
it.
> Stefan, I think it would be good to have a test for this in the test
> suite, even if for now it will fail.
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-10-23 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 21:24 bug#24767: jgraph comments not recognized any more Stefan Monnier
2016-10-23 6:17 ` Eli Zaretskii
2016-10-23 15:34 ` Alan Mackenzie [this message]
2016-10-24 19:34 ` Alan Mackenzie
2016-10-25 13:52 ` Stefan Monnier
2016-10-29 11:02 ` Alan Mackenzie
2016-10-29 15:12 ` Stefan Monnier
2016-10-30 17:37 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023153409.GA23704@acm.fritz.box \
--to=acm@muc.de \
--cc=24767@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).