From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#24767: jgraph comments not recognized any more Date: Tue, 25 Oct 2016 09:52:28 -0400 Message-ID: References: <20161024193451.GA4544@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477403615 27040 195.159.176.226 (25 Oct 2016 13:53:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 13:53:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 24767@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 25 15:53:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz2AK-0005Pt-SR for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 15:53:21 +0200 Original-Received: from localhost ([::1]:54654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2AM-00035a-Pv for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Oct 2016 09:53:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz2A7-00031I-1H for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 09:53:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz2A2-0007OJ-4U for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 09:53:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bz2A2-0007OD-0z for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bz2A1-0002uq-Mt for bug-gnu-emacs@gnu.org; Tue, 25 Oct 2016 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2016 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24767-submit@debbugs.gnu.org id=B24767.147740355811177 (code B ref 24767); Tue, 25 Oct 2016 13:53:01 +0000 Original-Received: (at 24767) by debbugs.gnu.org; 25 Oct 2016 13:52:38 +0000 Original-Received: from localhost ([127.0.0.1]:55831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz29d-0002uC-OK for submit@debbugs.gnu.org; Tue, 25 Oct 2016 09:52:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz29b-0002tw-Pg for 24767@debbugs.gnu.org; Tue, 25 Oct 2016 09:52:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AFBQALW9BX/1qOs2tdGgEBAQECAQEBAYMtAQEBAQEehE2FULF5hhYEAgKBaTwRAQIBAQEBAQEBXieEYgEBAwFWIwULCw4mEhQYDSQuiCcIvFUBAQEBBgIlin2KHAEEmVmZDYYLkEs0IIRsIIYKAQEB X-IPAS-Result: A0AFBQALW9BX/1qOs2tdGgEBAQECAQEBAYMtAQEBAQEehE2FULF5hhYEAgKBaTwRAQIBAQEBAQEBXieEYgEBAwFWIwULCw4mEhQYDSQuiCcIvFUBAQEBBgIlin2KHAEEmVmZDYYLkEs0IIRsIIYKAQEB X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="277046385" Original-Received: from 107-179-142-90.cpe.teksavvy.com (HELO ceviche.home) ([107.179.142.90]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Oct 2016 09:52:29 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 914FC6622D; Tue, 25 Oct 2016 09:52:28 -0400 (EDT) In-Reply-To: <20161024193451.GA4544@acm.fritz.box> (Alan Mackenzie's message of "Mon, 24 Oct 2016 19:34:51 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124989 Archived-At: > Suppose the jgraph buffer contains: > > he(*llo*) > > . Is this supposed to analyse as the symbol "he" followed by a comment, > or should it be the symbol "he(*llo*)"? Good question. To the extent that src/syntax.c shouldn't be specific to jgraph-mode, the answer shouldn't depend on the choice made by Jgraph's author. > Currently, even Emacs-25 doesn't recognise the "(*llo*)" as a comment. I think it's good enough to preserve backward compatibility, then. > It seems to me more likely that the comment should be recognised, but > I don't know jgraph. To choose which of the two behavior is desired, the major mode author can use syntax-propertize to catch this rare corner case anyway. > Maybe the solution (in master) would be to add the checking of the > comment flags into this subsidiary loop. Let's not worry about it. Stefan