unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@catern.com, 64428@debbugs.gnu.org
Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
Date: Thu, 06 Jul 2023 09:16:41 -0400	[thread overview]
Message-ID: <iersfa1i3ie.fsf@janestreet.com> (raw)
In-Reply-To: <83ilaxij8c.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jul 2023 10:37:07 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: sbaugh@catern.com
>> Date: Sun, 02 Jul 2023 21:51:01 +0000 (UTC)
>> 
>> This patch is based on the patch in bug#64425 (since I noticed this
>> unrelated issue while working on that, and they touch the same code).
>> 
>> 
>> 
>> When pixel-scroll-precision-mode is enabled, scrolling the mouse wheel
>> will yield wheel-{up,down} events.  flymake now binds the new events
>> in addition to the old mouse-wheel-{up,down}-event.
>> 
>> * lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev,
>> flymake--mode-line-counter-scroll-next,
>> flymake--mode-line-counter-map): Add.
>> (flymake--mode-line-counter): Use new keymap and include 'type as a
>> property in the mode-line.
>
> Thanks.  Any reason you couldn't simply add more events to the
> existing code?

Two reasons:

1. I initially did that but it made the code uglier.  Also, this code is
run every time the mode-line is updated, and adding more of that seems
bad.

2. This makes describe-key work better and makes it possible for users
to configure the scroll direction or add more bindings for different
things.






  reply	other threads:[~2023-07-06 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 21:51 bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode sbaugh
2023-07-06  7:37 ` Eli Zaretskii
2023-07-06 13:16   ` Spencer Baugh [this message]
2023-07-06 14:04     ` Eli Zaretskii
2023-07-07 11:37       ` João Távora
2023-07-07 11:47         ` João Távora
2023-07-07 12:12           ` sbaugh
2023-07-13  5:56             ` Eli Zaretskii
2023-07-13  8:12               ` João Távora
2023-07-13 14:00                 ` Eli Zaretskii
2023-07-07 12:52         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iersfa1i3ie.fsf@janestreet.com \
    --to=sbaugh@janestreet.com \
    --cc=64428@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).