From: sbaugh@catern.com
To: "João Távora" <joaotavora@gmail.com>
Cc: Spencer Baugh <sbaugh@janestreet.com>,
Eli Zaretskii <eliz@gnu.org>,
64428@debbugs.gnu.org
Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
Date: Fri, 07 Jul 2023 12:12:32 +0000 (UTC) [thread overview]
Message-ID: <87y1jrncnl.fsf@catern.com> (raw)
In-Reply-To: <CALDnm50wJ_rxF2K4pwst=qpcBPJp=WZNFXtdZXxGJf3m69-=sg@mail.gmail.com> ("João Távora"'s message of "Fri, 7 Jul 2023 12:47:10 +0100")
[-- Attachment #1: Type: text/plain, Size: 2221 bytes --]
João Távora <joaotavora@gmail.com> writes:
> On second thought, here are some comments that I think should be
> improved in Spencer's patch:
>
>> @@ -1479,21 +1505,8 @@ flymake--mode-line-counter
>> ((eq type :warning) "warnings")
>> ((eq type :note) "notes")
>> (t (format "%s diagnostics" type))))
>> - keymap
>> - ,(let ((map (make-sparse-keymap)))
>> - (define-key map (vector 'mode-line
>> - mouse-wheel-down-event)
>> - (lambda (event)
>> - (interactive "e")
>> - (with-selected-window (posn-window (event-start event))
>> - (flymake-goto-prev-error 1 (list type) t))))
>> - (define-key map (vector 'mode-line
>> - mouse-wheel-up-event)
>> - (lambda (event)
>> - (interactive "e")
>> - (with-selected-window (posn-window (event-start event))
>> - (flymake-goto-next-error 1 (list type) t))))
>> - map))))))
>> + type ,type
>
> Spencer, here you are recording the value of the `type` in a `type`
> text-property of the affected text. Generally, though this rule
> isn't enforced or always followed (at least by me), it's better
> to give these package-specific properties some longer
> package-specific name like `flymake--diagnostic-type`. This will
> prevent any clashes if the less-qualified `type` is ever defined
> to mean something else as a text-property.
>
>> + (interactive "e")
>> + (let* ((posn-string (posn-string (event-start event)))
>> + (type (get-text-property (cdr posn-string) 'type (car posn-string))))
>> + (with-selected-window (posn-window (event-start event))
>> + (flymake-goto-prev-error 1 (list type) t))))
>
> And here, you could consider saving the value of (event-start event)
> by adding another early binding to that `let*`, maybe call it `estart`.
> This is much less important than the first comment though.
>
> João
Fixed.
I have tested in both graphical and tty Emacs.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-flymake-mode-line-scrolling-with-pixel-scroll-pr.patch --]
[-- Type: text/x-patch, Size: 3747 bytes --]
From c369c3b99ef1e5f9eab29f99a9d4f354352ef05b Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@catern.com>
Date: Sun, 2 Jul 2023 17:49:23 -0400
Subject: [PATCH] Fix flymake mode line scrolling with
pixel-scroll-precision-mode
When pixel-scroll-precision-mode is enabled, scrolling the mouse wheel
will yield wheel-{up,down} events. flymake now binds the new events
in addition to the old mouse-wheel-{up,down}-event.
* lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev,
flymake--mode-line-counter-scroll-next,
flymake--mode-line-counter-map): Add.
(flymake--mode-line-counter): Use new keymap and include
flymake--diagnostic-type as a property in the mode-line.
---
lisp/progmodes/flymake.el | 47 ++++++++++++++++++++++++++-------------
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 47dc32f9245..17154b646d7 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1449,6 +1449,36 @@ flymake--mode-line-exception
(defun flymake--mode-line-counters ()
(when (flymake-running-backends) flymake-mode-line-counter-format))
+(defun flymake--mode-line-counter-scroll-prev (event)
+ (interactive "e")
+ (let* ((event-start (event-start event))
+ (posn-string (posn-string event-start))
+ (type (get-text-property
+ (cdr posn-string) 'flymake--diagnostic-type (car posn-string))))
+ (with-selected-window (posn-window event-start)
+ (flymake-goto-prev-error 1 (list type) t))))
+
+(defun flymake--mode-line-counter-scroll-next (event)
+ (interactive "e")
+ (let* ((event-start (event-start event))
+ (posn-string (posn-string event-start))
+ (type (get-text-property
+ (cdr posn-string) 'flymake--diagnostic-type (car posn-string))))
+ (with-selected-window (posn-window event-start)
+ (flymake-goto-next-error 1 (list type) t))))
+
+(defvar flymake--mode-line-counter-map
+ (let ((map (make-sparse-keymap)))
+ (define-key map (vector 'mode-line mouse-wheel-down-event)
+ #'flymake--mode-line-counter-scroll-prev)
+ (define-key map [mode-line wheel-down]
+ #'flymake--mode-line-counter-scroll-prev)
+ (define-key map (vector 'mode-line mouse-wheel-up-event)
+ #'flymake--mode-line-counter-scroll-next)
+ (define-key map [mode-line wheel-up]
+ #'flymake--mode-line-counter-scroll-next)
+ map))
+
(defun flymake--mode-line-counter (type &optional no-space)
"Compute number of diagnostics in buffer with TYPE's severity.
TYPE is usually keyword `:error', `:warning' or `:note'."
@@ -1479,21 +1509,8 @@ flymake--mode-line-counter
((eq type :warning) "warnings")
((eq type :note) "notes")
(t (format "%s diagnostics" type))))
- keymap
- ,(let ((map (make-sparse-keymap)))
- (define-key map (vector 'mode-line
- mouse-wheel-down-event)
- (lambda (event)
- (interactive "e")
- (with-selected-window (posn-window (event-start event))
- (flymake-goto-prev-error 1 (list type) t))))
- (define-key map (vector 'mode-line
- mouse-wheel-up-event)
- (lambda (event)
- (interactive "e")
- (with-selected-window (posn-window (event-start event))
- (flymake-goto-next-error 1 (list type) t))))
- map))))))
+ flymake--diagnostic-type ,type
+ keymap ,flymake--mode-line-counter-map)))))
;;; Per-buffer diagnostic listing
--
2.41.0
next prev parent reply other threads:[~2023-07-07 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 21:51 bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode sbaugh
2023-07-06 7:37 ` Eli Zaretskii
2023-07-06 13:16 ` Spencer Baugh
2023-07-06 14:04 ` Eli Zaretskii
2023-07-07 11:37 ` João Távora
2023-07-07 11:47 ` João Távora
2023-07-07 12:12 ` sbaugh [this message]
2023-07-13 5:56 ` Eli Zaretskii
2023-07-13 8:12 ` João Távora
2023-07-13 14:00 ` Eli Zaretskii
2023-07-07 12:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1jrncnl.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=64428@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).