From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Spencer Baugh <sbaugh@janestreet.com>,
64428@debbugs.gnu.org, sbaugh@catern.com
Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
Date: Fri, 7 Jul 2023 12:47:10 +0100 [thread overview]
Message-ID: <CALDnm50wJ_rxF2K4pwst=qpcBPJp=WZNFXtdZXxGJf3m69-=sg@mail.gmail.com> (raw)
In-Reply-To: <CALDnm52BdcJck-BWc=OzYvZxUzz8vPy0SxkY9Qgq9jKjA2q71w@mail.gmail.com>
On second thought, here are some comments that I think should be
improved in Spencer's patch:
> @@ -1479,21 +1505,8 @@ flymake--mode-line-counter
> ((eq type :warning) "warnings")
> ((eq type :note) "notes")
> (t (format "%s diagnostics" type))))
> - keymap
> - ,(let ((map (make-sparse-keymap)))
> - (define-key map (vector 'mode-line
> - mouse-wheel-down-event)
> - (lambda (event)
> - (interactive "e")
> - (with-selected-window (posn-window (event-start event))
> - (flymake-goto-prev-error 1 (list type) t))))
> - (define-key map (vector 'mode-line
> - mouse-wheel-up-event)
> - (lambda (event)
> - (interactive "e")
> - (with-selected-window (posn-window (event-start event))
> - (flymake-goto-next-error 1 (list type) t))))
> - map))))))
> + type ,type
Spencer, here you are recording the value of the `type` in a `type`
text-property of the affected text. Generally, though this rule
isn't enforced or always followed (at least by me), it's better
to give these package-specific properties some longer
package-specific name like `flymake--diagnostic-type`. This will
prevent any clashes if the less-qualified `type` is ever defined
to mean something else as a text-property.
> + (interactive "e")
> + (let* ((posn-string (posn-string (event-start event)))
> + (type (get-text-property (cdr posn-string) 'type (car posn-string))))
> + (with-selected-window (posn-window (event-start event))
> + (flymake-goto-prev-error 1 (list type) t))))
And here, you could consider saving the value of (event-start event)
by adding another early binding to that `let*`, maybe call it `estart`.
This is much less important than the first comment though.
João
next prev parent reply other threads:[~2023-07-07 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 21:51 bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode sbaugh
2023-07-06 7:37 ` Eli Zaretskii
2023-07-06 13:16 ` Spencer Baugh
2023-07-06 14:04 ` Eli Zaretskii
2023-07-07 11:37 ` João Távora
2023-07-07 11:47 ` João Távora [this message]
2023-07-07 12:12 ` sbaugh
2023-07-13 5:56 ` Eli Zaretskii
2023-07-13 8:12 ` João Távora
2023-07-13 14:00 ` Eli Zaretskii
2023-07-07 12:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50wJ_rxF2K4pwst=qpcBPJp=WZNFXtdZXxGJf3m69-=sg@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=64428@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).