From: Spencer Baugh <sbaugh@janestreet.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 66993@debbugs.gnu.org
Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock
Date: Wed, 08 Nov 2023 10:06:27 -0500 [thread overview]
Message-ID: <iero7g4thcc.fsf@janestreet.com> (raw)
In-Reply-To: <7089f7f2-3000-75fe-768a-dd12d979d81c@gutov.dev> (Dmitry Gutov's message of "Wed, 8 Nov 2023 02:24:13 +0200")
Dmitry Gutov <dmitry@gutov.dev> writes:
> On 07/11/2023 23:28, Spencer Baugh wrote:
>> - project-mode-line will call this on mode-line update
>
> Hopefully this will never result in writes to disk made more often
> than once per user command, or buffer switch, etc.
>
>> - (write-region nil nil filename nil 'silent))))
>> + ;; If project-list-file is locked by some other Emacs, fail to
>> + ;; write rather than prompting the user.
>> + (ignore-error file-locked
>> + (cl-letf (((symbol-function 'ask-user-about-lock)
>> + (lambda (file opponent)
>> + (signal 'file-locked (list file opponent)))))
>> + (write-region nil nil filename nil 'silent))))))
>
> I wonder if all cl-letf uses like this will survive native
> compilation, for example. Or will break over time due to internal
> changes in the function.
>
> Anyway, maybe an implementation like this (totally untested)?
>
> Or the warning could be skipped entirely.
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index a6426c08840..e544dfefa73 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1719,7 +1719,9 @@ project--write-project-list
> (expand-file-name name)))))
> project--list)
> (current-buffer)))
> - (write-region nil nil filename nil 'silent))))
> + (let ((noninteractive t))
> + (with-demoted-errors "Failed to save file list: %S"
> + (write-region nil nil filename nil 'silent))))))
>
> ;;;###autoload
> (defun project-remember-project (pr &optional no-write)
Good idea using noninteractive. I agree that should signal file-locked,
so we can handle it. That seems like the most elegant solution.
However, interestingly, this actually seems to crash Emacs! Not sure
why yet.
Reproduction:
1. Open ~/file and edit it without saving (so Emacs takes the lock)
2. in a separate emacs -Q, run with M-:
(let ((noninteractive t)) (write-region nil nil "~/file"))
3. Notice the separate emacs -Q immediately crashes!
This is really a separate bug, but since we're talking about
noninteractively handling lock conflicts, we might as well solve it here
- or decide if it really should be solved.
next prev parent reply other threads:[~2023-11-08 15:06 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:28 bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Spencer Baugh
2023-11-08 0:24 ` Dmitry Gutov
2023-11-08 12:29 ` Eli Zaretskii
2023-11-08 13:20 ` Dmitry Gutov
2023-11-08 15:06 ` Spencer Baugh [this message]
2023-11-08 7:46 ` Michael Albinus
2023-11-08 14:52 ` Spencer Baugh
2023-11-08 15:44 ` Michael Albinus
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 12:22 ` Eli Zaretskii
2023-11-08 13:26 ` Dmitry Gutov
2023-11-08 13:50 ` Eli Zaretskii
2023-11-08 13:56 ` Dmitry Gutov
2023-11-08 15:31 ` Eli Zaretskii
2023-11-08 15:41 ` Spencer Baugh
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 17:05 ` Spencer Baugh
2023-11-08 17:43 ` Eli Zaretskii
2023-11-08 20:43 ` Spencer Baugh
2023-11-09 6:32 ` Eli Zaretskii
2023-11-09 16:38 ` Spencer Baugh
2023-11-09 16:52 ` Eli Zaretskii
2023-11-09 18:01 ` Spencer Baugh
2023-11-09 19:46 ` Eli Zaretskii
2023-11-10 12:48 ` Spencer Baugh
2023-11-15 13:38 ` Eli Zaretskii
2023-11-08 15:36 ` Spencer Baugh
2023-11-08 16:32 ` Eli Zaretskii
2023-11-08 21:04 ` Dmitry Gutov
2023-11-09 6:37 ` Eli Zaretskii
2023-11-09 11:05 ` Dmitry Gutov
2023-11-09 11:27 ` Eli Zaretskii
2023-11-09 11:33 ` Dmitry Gutov
2023-11-09 14:50 ` Eli Zaretskii
2023-11-15 15:40 ` Spencer Baugh
2023-11-15 20:49 ` Spencer Baugh
2023-11-18 1:41 ` Dmitry Gutov
2023-11-18 15:48 ` sbaugh
2023-11-18 15:56 ` sbaugh
2023-11-18 16:26 ` Eli Zaretskii
2023-11-18 23:10 ` Spencer Baugh
2023-11-19 6:05 ` Eli Zaretskii
2023-11-19 14:54 ` Spencer Baugh
2023-11-19 14:31 ` Dmitry Gutov
2023-11-19 15:23 ` Eli Zaretskii
2023-11-20 2:05 ` Dmitry Gutov
2023-11-20 11:57 ` Eli Zaretskii
2023-11-19 14:33 ` Dmitry Gutov
2023-11-19 17:52 ` Juri Linkov
2023-11-19 19:38 ` Spencer Baugh
2023-11-20 1:19 ` Dmitry Gutov
2023-11-08 21:03 ` Dmitry Gutov
2023-11-08 13:58 ` Dmitry Gutov
2023-11-08 15:25 ` Spencer Baugh
2023-11-08 21:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iero7g4thcc.fsf@janestreet.com \
--to=sbaugh@janestreet.com \
--cc=66993@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).