From: Dmitry Gutov <dmitry@gutov.dev>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 66993@debbugs.gnu.org
Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock
Date: Wed, 8 Nov 2023 23:14:36 +0200 [thread overview]
Message-ID: <4a7ef18e-f559-8835-22f4-3bb987e5e752@gutov.dev> (raw)
In-Reply-To: <ierjzqstgh8.fsf@janestreet.com>
On 08/11/2023 17:25, Spencer Baugh wrote:
> - Concurrent calls to regular project commands
> (e.g. project-async-shell-command or project-compile) from two
> Emacsen,
> since those set MAYBE-PROMPT=t
Since they are usually triggered manually, the user will have to try
hard to launch them at the same time.
> - Concurrent calls to project-remember-project/project-forget-project
> and similar functions. (This is what my project-watch does, since it
> calls project-remember-project when a new project shows up in a
> directory, and if I'm unlucky that will be at the same time as another
> Emacs instance.)
Note that if your code triggers the rewrites of the project-list file
frequently enough so that the conflicts happen, doing more work during
that time (e.g. reading, re-serializing, and then writing the file)
might actually cause some disk/CPU usage increase. (Although if the
conflicts happen due to synchronous firing of inotify watches in
parallel Emacs instances, then probably not.)
BTW, the merging algorithm to use it is not very obvious (especially if
we're going to do that in kill-emacs-hook). E.g. if one instance removed
a project from history and another did not, we probably want to have it
removed in the "merged" version.
> I guess that makes it less of a critical issue, but it still seems to me
> that this is worth fixing.
I'm glad to hear that the current design is working fine for the
expected usage scenarios, but indeed, why not make it more resilient. If
we don't sacrifice too much of something else.
prev parent reply other threads:[~2023-11-08 21:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:28 bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Spencer Baugh
2023-11-08 0:24 ` Dmitry Gutov
2023-11-08 12:29 ` Eli Zaretskii
2023-11-08 13:20 ` Dmitry Gutov
2023-11-08 15:06 ` Spencer Baugh
2023-11-08 7:46 ` Michael Albinus
2023-11-08 14:52 ` Spencer Baugh
2023-11-08 15:44 ` Michael Albinus
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 12:22 ` Eli Zaretskii
2023-11-08 13:26 ` Dmitry Gutov
2023-11-08 13:50 ` Eli Zaretskii
2023-11-08 13:56 ` Dmitry Gutov
2023-11-08 15:31 ` Eli Zaretskii
2023-11-08 15:41 ` Spencer Baugh
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 17:05 ` Spencer Baugh
2023-11-08 17:43 ` Eli Zaretskii
2023-11-08 20:43 ` Spencer Baugh
2023-11-09 6:32 ` Eli Zaretskii
2023-11-09 16:38 ` Spencer Baugh
2023-11-09 16:52 ` Eli Zaretskii
2023-11-09 18:01 ` Spencer Baugh
2023-11-09 19:46 ` Eli Zaretskii
2023-11-10 12:48 ` Spencer Baugh
2023-11-15 13:38 ` Eli Zaretskii
2023-11-08 15:36 ` Spencer Baugh
2023-11-08 16:32 ` Eli Zaretskii
2023-11-08 21:04 ` Dmitry Gutov
2023-11-09 6:37 ` Eli Zaretskii
2023-11-09 11:05 ` Dmitry Gutov
2023-11-09 11:27 ` Eli Zaretskii
2023-11-09 11:33 ` Dmitry Gutov
2023-11-09 14:50 ` Eli Zaretskii
2023-11-15 15:40 ` Spencer Baugh
2023-11-15 20:49 ` Spencer Baugh
2023-11-18 1:41 ` Dmitry Gutov
2023-11-18 15:48 ` sbaugh
2023-11-18 15:56 ` sbaugh
2023-11-18 16:26 ` Eli Zaretskii
2023-11-18 23:10 ` Spencer Baugh
2023-11-19 6:05 ` Eli Zaretskii
2023-11-19 14:54 ` Spencer Baugh
2023-11-19 14:31 ` Dmitry Gutov
2023-11-19 15:23 ` Eli Zaretskii
2023-11-20 2:05 ` Dmitry Gutov
2023-11-20 11:57 ` Eli Zaretskii
2023-11-19 14:33 ` Dmitry Gutov
2023-11-19 17:52 ` Juri Linkov
2023-11-19 19:38 ` Spencer Baugh
2023-11-20 1:19 ` Dmitry Gutov
2023-11-08 21:03 ` Dmitry Gutov
2023-11-08 13:58 ` Dmitry Gutov
2023-11-08 15:25 ` Spencer Baugh
2023-11-08 21:14 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a7ef18e-f559-8835-22f4-3bb987e5e752@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66993@debbugs.gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).