From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: dmitry@gutov.dev, 66993@debbugs.gnu.org
Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock
Date: Thu, 09 Nov 2023 18:52:19 +0200 [thread overview]
Message-ID: <83bkc2zx6k.fsf@gnu.org> (raw)
In-Reply-To: <ierbkc2swzh.fsf@janestreet.com> (message from Spencer Baugh on Thu, 09 Nov 2023 11:38:26 -0500)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: dmitry@gutov.dev, 66993@debbugs.gnu.org
> Date: Thu, 09 Nov 2023 11:38:26 -0500
>
> > That's one way, yes. Another one is to use define-error to define a
> > new error type for this case.
>
> Instead of defining a new error type, how about just signaling
> file-locked instead? e.g. the following patch:
>
> diff --git a/lisp/userlock.el b/lisp/userlock.el
> index 61f061d3e54..e4d23c56249 100644
> --- a/lisp/userlock.el
> +++ b/lisp/userlock.el
> @@ -67,7 +67,7 @@ ask-user-about-lock
> (message (substitute-command-keys
> "%s locked by %s: (\\`s', \\`q', \\`p', \\`?')? ")
> short-file short-opponent)
> - (if noninteractive (error "Cannot resolve lock conflict in batch mode"))
> + (if noninteractive (signal 'file-locked (list file opponent)))
> (let ((tem (let ((inhibit-quit t)
> (cursor-in-echo-area t))
> (prog1 (downcase (read-char))
Please show the result of this change on what Emacs prints in batch
mode when this error is signaled.
next prev parent reply other threads:[~2023-11-09 16:52 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:28 bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Spencer Baugh
2023-11-08 0:24 ` Dmitry Gutov
2023-11-08 12:29 ` Eli Zaretskii
2023-11-08 13:20 ` Dmitry Gutov
2023-11-08 15:06 ` Spencer Baugh
2023-11-08 7:46 ` Michael Albinus
2023-11-08 14:52 ` Spencer Baugh
2023-11-08 15:44 ` Michael Albinus
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 12:22 ` Eli Zaretskii
2023-11-08 13:26 ` Dmitry Gutov
2023-11-08 13:50 ` Eli Zaretskii
2023-11-08 13:56 ` Dmitry Gutov
2023-11-08 15:31 ` Eli Zaretskii
2023-11-08 15:41 ` Spencer Baugh
2023-11-08 16:35 ` Eli Zaretskii
2023-11-08 17:05 ` Spencer Baugh
2023-11-08 17:43 ` Eli Zaretskii
2023-11-08 20:43 ` Spencer Baugh
2023-11-09 6:32 ` Eli Zaretskii
2023-11-09 16:38 ` Spencer Baugh
2023-11-09 16:52 ` Eli Zaretskii [this message]
2023-11-09 18:01 ` Spencer Baugh
2023-11-09 19:46 ` Eli Zaretskii
2023-11-10 12:48 ` Spencer Baugh
2023-11-15 13:38 ` Eli Zaretskii
2023-11-08 15:36 ` Spencer Baugh
2023-11-08 16:32 ` Eli Zaretskii
2023-11-08 21:04 ` Dmitry Gutov
2023-11-09 6:37 ` Eli Zaretskii
2023-11-09 11:05 ` Dmitry Gutov
2023-11-09 11:27 ` Eli Zaretskii
2023-11-09 11:33 ` Dmitry Gutov
2023-11-09 14:50 ` Eli Zaretskii
2023-11-15 15:40 ` Spencer Baugh
2023-11-15 20:49 ` Spencer Baugh
2023-11-18 1:41 ` Dmitry Gutov
2023-11-18 15:48 ` sbaugh
2023-11-18 15:56 ` sbaugh
2023-11-18 16:26 ` Eli Zaretskii
2023-11-18 23:10 ` Spencer Baugh
2023-11-19 6:05 ` Eli Zaretskii
2023-11-19 14:54 ` Spencer Baugh
2023-11-19 14:31 ` Dmitry Gutov
2023-11-19 15:23 ` Eli Zaretskii
2023-11-20 2:05 ` Dmitry Gutov
2023-11-20 11:57 ` Eli Zaretskii
2023-11-19 14:33 ` Dmitry Gutov
2023-11-19 17:52 ` Juri Linkov
2023-11-19 19:38 ` Spencer Baugh
2023-11-20 1:19 ` Dmitry Gutov
2023-11-08 21:03 ` Dmitry Gutov
2023-11-08 13:58 ` Dmitry Gutov
2023-11-08 15:25 ` Spencer Baugh
2023-11-08 21:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkc2zx6k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66993@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).