unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Spencer Baugh <sbaugh@janestreet.com>
To: 63470@debbugs.gnu.org
Subject: bug#63470: [PATCH] Use faster option for running vc-hg status
Date: Fri, 12 May 2023 15:28:43 -0400	[thread overview]
Message-ID: <ier7ctdfixg.fsf@janestreet.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Tags: patch




In GNU Emacs 29.0.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-05-09 built on
 igm-qws-u22796a
Repository revision: 65c4a24aa0fc672bbf11e0c5187c6a29931b4363
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-gif=ifavailable'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-faster-option-for-running-vc-hg-status.patch --]
[-- Type: text/patch, Size: 1484 bytes --]

From 6fe0d4485b40f67473cad97f1b57c702dbeb3f57 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@janestreet.com>
Date: Fri, 12 May 2023 15:28:06 -0400
Subject: [PATCH] Use faster option for running vc-hg status

As the comment says, this causes us to depend on Mercurial 4.2, which
was released in 2017.  However, in modern Mercurial, removing the
"re:" "-I" "." options provides a 10x-20x speedup (because it allows
the Rust implementation of "hg status" to be used), so it's certainly
worth losing this compatibility.

* lisp/vc/vc-hg.el (vc-hg-dir-status-files):
Use --config status.relative=1 to make paths relative
---
 lisp/vc/vc-hg.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 78231a0c954..2f6e5bc5e19 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -1381,11 +1381,9 @@ vc-hg-dir-status-files
   ;; XXX: We can't pass DIR directly to 'hg status' because that
   ;; returns all ignored files if FILES is non-nil (bug#22481).
   (let ((default-directory dir))
-    ;; TODO: Use "--config 'status.relative=1'" instead of "re:"
-    ;; when we're allowed to depend on Mercurial 4.2+
-    ;; (it's a bit faster).
     (vc-hg-command (current-buffer) 'async files
-                   "status" "re:" "-I" "."
+                   "--config" "status.relative=1"
+                   "status"
                    (concat "-mardu" (if files "i"))
                    "-C"))
   (vc-run-delayed
-- 
2.30.2


             reply	other threads:[~2023-05-12 19:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 19:28 Spencer Baugh [this message]
2023-05-12 19:43 ` bug#63470: [PATCH] Use faster option for running vc-hg status Eli Zaretskii
2023-05-12 19:57   ` Spencer Baugh
2023-05-12 20:10     ` Dmitry Gutov
2023-05-13  5:54       ` Eli Zaretskii
2023-05-16 20:39         ` Spencer Baugh
2023-05-17 11:39           ` Eli Zaretskii
2023-05-17 11:47             ` Spencer Baugh
2023-05-17 11:55               ` Eli Zaretskii
2023-05-22 17:58                 ` Spencer Baugh
2023-05-22 22:33                   ` Dmitry Gutov
2023-05-18 23:48           ` Dmitry Gutov
2023-05-19 14:34             ` Spencer Baugh
2023-05-22 22:33               ` Dmitry Gutov
2023-05-13  5:51     ` Eli Zaretskii
2023-05-12 20:06   ` Dmitry Gutov
2023-05-13  5:52     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ier7ctdfixg.fsf@janestreet.com \
    --to=sbaugh@janestreet.com \
    --cc=63470@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).