unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: dmitry@gutov.dev, 63470@debbugs.gnu.org
Subject: bug#63470: [PATCH] Use faster option for running vc-hg status
Date: Wed, 17 May 2023 14:39:45 +0300	[thread overview]
Message-ID: <83o7mjxk3i.fsf@gnu.org> (raw)
In-Reply-To: <ierbkikovsa.fsf@janestreet.com> (message from Spencer Baugh on Tue, 16 May 2023 16:39:49 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: Dmitry Gutov <dmitry@gutov.dev>,  63470@debbugs.gnu.org
> Date: Tue, 16 May 2023 16:39:49 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Date: Fri, 12 May 2023 23:10:05 +0300
> >> Cc: 63470@debbugs.gnu.org
> >> From: Dmitry Gutov <dmitry@gutov.dev>
> >> 
> >> On 12/05/2023 22:57, Spencer Baugh wrote:
> >> > 
> >> > I could add a user option to revert to the old behavior, if you want.
> >> 
> >> We could cache it like we do with vc-git--program-version. That's a 
> >> simple memoization that doesn't take the host into account (though that 
> >> could be implemented, too).
> >
> > Yes, that'd be a good-enough solution.
> >
> >> But it'd really make things easier if we're just allowed to rely on some 
> >> new enough versions of Git and Hg.
> >
> > It isn't easy to be backward-compatible, but we should strive at doing
> > that.
> 
> OK, revised backwards-compatible patch attached.

Thanks, but I'd prefer to call the new function only once, and record
the result in some variable.  We do such things in umpteen other
places, so it looks strange to test the version each time only in this
case.

If you are afraid that somehow the version could change while the
Emacs session runs, we could add a command to recompute the version.
I think it's reasonable to ask the user to do this by hand, since
installing a new version of Mercurial should be something users are
aware of.





  reply	other threads:[~2023-05-17 11:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 19:28 bug#63470: [PATCH] Use faster option for running vc-hg status Spencer Baugh
2023-05-12 19:43 ` Eli Zaretskii
2023-05-12 19:57   ` Spencer Baugh
2023-05-12 20:10     ` Dmitry Gutov
2023-05-13  5:54       ` Eli Zaretskii
2023-05-16 20:39         ` Spencer Baugh
2023-05-17 11:39           ` Eli Zaretskii [this message]
2023-05-17 11:47             ` Spencer Baugh
2023-05-17 11:55               ` Eli Zaretskii
2023-05-22 17:58                 ` Spencer Baugh
2023-05-22 22:33                   ` Dmitry Gutov
2023-05-18 23:48           ` Dmitry Gutov
2023-05-19 14:34             ` Spencer Baugh
2023-05-22 22:33               ` Dmitry Gutov
2023-05-13  5:51     ` Eli Zaretskii
2023-05-12 20:06   ` Dmitry Gutov
2023-05-13  5:52     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o7mjxk3i.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63470@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).