unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 63470@debbugs.gnu.org
Subject: bug#63470: [PATCH] Use faster option for running vc-hg status
Date: Sat, 13 May 2023 08:51:24 +0300	[thread overview]
Message-ID: <83fs80bwyr.fsf@gnu.org> (raw)
In-Reply-To: <ier4johfhl6.fsf@janestreet.com> (message from Spencer Baugh on Fri, 12 May 2023 15:57:41 -0400)

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: 63470@debbugs.gnu.org
> Date: Fri, 12 May 2023 15:57:41 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> > I don't understand: what will happen to users of Mercurial < 4.2?
> 
> They will get an error message and the vc-dir buffer will fail to
> update.

That's unacceptable, sorry.  There are better solutions than just stop
supporting those users, so this is too harsh.

> > And why cannot we detect the version and dispatch on that, instead of
> > doing this unconditionally?
> 
> hg --version takes a quarter of a second on my machine, which itself
> wipes out a lot of the performance benefit.  We could cache it, but it's
> not clear to me how to do that correctly: there could be different hg
> binaries in different directories, or over TRAMP, or other such things.

There's no reason to assume there's more than one Mercurial
installation on PATH.  We could allow reinitialization of the version,
but that would be holier that Pope, IMO.  We don't do that with Git,
AFAIR.

> I could add a user option to revert to the old behavior, if you want.

The result of the version test could set the value of the defacustom,
but if we add such a defcustom, its default value should be to probe
the system, not to assume version 4.2 or later.

> (It would be nice if vc was available on ELPA, then maybe we could just
> tell users of old mercurial versions to downgrade to an old version...)

Does package.el support downgrading of packages, let alone of built-in
packages?





  parent reply	other threads:[~2023-05-13  5:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 19:28 bug#63470: [PATCH] Use faster option for running vc-hg status Spencer Baugh
2023-05-12 19:43 ` Eli Zaretskii
2023-05-12 19:57   ` Spencer Baugh
2023-05-12 20:10     ` Dmitry Gutov
2023-05-13  5:54       ` Eli Zaretskii
2023-05-16 20:39         ` Spencer Baugh
2023-05-17 11:39           ` Eli Zaretskii
2023-05-17 11:47             ` Spencer Baugh
2023-05-17 11:55               ` Eli Zaretskii
2023-05-22 17:58                 ` Spencer Baugh
2023-05-22 22:33                   ` Dmitry Gutov
2023-05-18 23:48           ` Dmitry Gutov
2023-05-19 14:34             ` Spencer Baugh
2023-05-22 22:33               ` Dmitry Gutov
2023-05-13  5:51     ` Eli Zaretskii [this message]
2023-05-12 20:06   ` Dmitry Gutov
2023-05-13  5:52     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fs80bwyr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63470@debbugs.gnu.org \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).