bug#2495: 23.0.91; regression in M-x flush-lines

bug#2495: 23.0.91; regression in M-x flush-lines

[Andreas Seltenreich]

> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.

> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

> Please describe exactly what actions triggered the bug

emacs -Q
M-< ; beginning of *scratch* buffer
M-x flush-lines RET RET

> and the precise symptoms of the bug:

Lines matching the empty regexp are not flushed.  This used to work in
older releases.

Thanks,
andreas

> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>     `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /home/andreas/ext/emacs/etc/DEBUG for instructions.

In GNU Emacs 23.0.91.2 (x86_64-unknown-linux-gnu, X toolkit)
 of 2009-02-26 on tengen
configured using `configure  '--enable-debug' --enable-ltdl-convenience'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  show-paren-mode: t
  rcirc-track-minor-mode: t
  display-time-mode: t
  savehist-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  abbrev-mode: t

bug#2495: marked as done (23.0.91; regression in M-x flush-lines)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]


Your message dated Fri, 27 Feb 2009 10:33:29 -0500
with message-id <87fxhzzygm.fsf@cyd.mit.edu>
and subject line Re: 23.0.91; regression in M-x flush-lines
has caused the Emacs bug report #2495,
regarding 23.0.91; regression in M-x flush-lines
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2495: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2495
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4169 bytes --]

From: Andreas Seltenreich <seltenreich@gmx.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 14:20:35 +0100
Message-ID: <874oyg8198.fsf@gate450.dyndns.org>

> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.

> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

> Please describe exactly what actions triggered the bug

emacs -Q
M-< ; beginning of *scratch* buffer
M-x flush-lines RET RET

> and the precise symptoms of the bug:

Lines matching the empty regexp are not flushed.  This used to work in
older releases.

Thanks,
andreas

> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>     `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /home/andreas/ext/emacs/etc/DEBUG for instructions.

In GNU Emacs 23.0.91.2 (x86_64-unknown-linux-gnu, X toolkit)
 of 2009-02-26 on tengen
configured using `configure  '--enable-debug' --enable-ltdl-convenience'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  show-paren-mode: t
  rcirc-track-minor-mode: t
  display-time-mode: t
  savehist-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  abbrev-mode: t



[-- Attachment #3: Type: message/rfc822, Size: 1278 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Andreas Seltenreich <seltenreich@gmx.de>
Cc: 2495-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 10:33:29 -0500
Message-ID: <87fxhzzygm.fsf@cyd.mit.edu>

> emacs -Q
> M-< ; beginning of *scratch* buffer
> M-x flush-lines RET RET
>
> Lines matching the empty regexp are not flushed.  This used to work in
> older releases.

Thanks for spotting this.  I've checked in a fix to CVS.

bug#2495: 23.0.91; regression in M-x flush-lines

[Glenn Morris]

Andreas Seltenreich wrote:

> emacs -Q
> M-< ; beginning of *scratch* buffer
> M-x flush-lines RET RET

In 22.3, this used read-from-minibuffer, which returns the empty
string in case of no input.

Now it used read-regexp, which returns nil in case of no input (if no
default is supplied). That doesn't seem right.

Perhaps this:


*** replace.el	9 Jan 2009 05:01:00 -0000	1.282
--- replace.el	27 Feb 2009 21:41:59 -0000
***************
*** 556,562 ****
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	default-value
        (prog1 input
  	(add-to-history 'regexp-history input)))))
  
--- 556,562 ----
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	(or default-value input)
        (prog1 input
  	(add-to-history 'regexp-history input)))))

bug#2495: 23.0.91; regression in M-x flush-lines

[Juri Linkov]

>> emacs -Q
>> M-< ; beginning of *scratch* buffer
>> M-x flush-lines RET RET
>
> In 22.3, this used read-from-minibuffer, which returns the empty
> string in case of no input.
>
> Now it used read-regexp, which returns nil in case of no input (if no
> default is supplied). That doesn't seem right.
>
> Perhaps this:
>
> *** replace.el	9 Jan 2009 05:01:00 -0000	1.282
> --- replace.el	27 Feb 2009 21:41:59 -0000
> ***************
> *** 556,562 ****
>   	     (format "%s: " prompt))
>   	   nil nil nil 'regexp-history defaults t)))
>       (if (equal input "")
> ! 	default-value
>         (prog1 input
>   	(add-to-history 'regexp-history input)))))
>   
> --- 556,562 ----
>   	     (format "%s: " prompt))
>   	   nil nil nil 'regexp-history defaults t)))
>       (if (equal input "")
> ! 	(or default-value input)
>         (prog1 input
>   	(add-to-history 'regexp-history input)))))

Currently flush-lines always displays the misleading prompt

  Flush lines containing match for regexp (default ):
                                          ==========

where default is empty that makes no sense without a real
default value.

I think Glenn provided the correct patch for this bug (seen above).

-- 
Juri Linkov
http://www.jurta.org/emacs/

Processed: Re: bug#2495: 23.0.91; regression in M-x flush-lines

[Emacs bug Tracking System]

Processing commands for control@emacsbugs.donarmstrong.com:

> unarchive 2495
Bug 2495 [emacs] 23.0.91; regression in M-x flush-lines
Unarchived bug 2495
> thanks
Stopping processing here.

Please contact me if you need assistance.

Don Armstrong
(administrator, Emacs bugs database)