unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Andreas Seltenreich <seltenreich@gmx.de>
Cc: 2495@emacsbugs.donarmstrong.com
Subject: bug#2495: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 16:41:10 -0500	[thread overview]
Message-ID: <y21vtjo8w9.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <874oyg8198.fsf@gate450.dyndns.org> (Andreas Seltenreich's message of "Fri, 27 Feb 2009 14:20:35 +0100")

Andreas Seltenreich wrote:

> emacs -Q
> M-< ; beginning of *scratch* buffer
> M-x flush-lines RET RET

In 22.3, this used read-from-minibuffer, which returns the empty
string in case of no input.

Now it used read-regexp, which returns nil in case of no input (if no
default is supplied). That doesn't seem right.

Perhaps this:


*** replace.el	9 Jan 2009 05:01:00 -0000	1.282
--- replace.el	27 Feb 2009 21:41:59 -0000
***************
*** 556,562 ****
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	default-value
        (prog1 input
  	(add-to-history 'regexp-history input)))))
  
--- 556,562 ----
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	(or default-value input)
        (prog1 input
  	(add-to-history 'regexp-history input)))))






  parent reply	other threads:[~2009-02-27 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87fxhzzygm.fsf@cyd.mit.edu>
2009-02-27 13:20 ` bug#2495: 23.0.91; regression in M-x flush-lines Andreas Seltenreich
2009-02-27 15:35   ` bug#2495: marked as done (23.0.91; regression in M-x flush-lines) Emacs bug Tracking System
2009-02-27 21:41   ` Glenn Morris [this message]
2009-08-05 20:14     ` bug#2495: 23.0.91; regression in M-x flush-lines Juri Linkov
2009-08-05 20:25       ` Processed: " Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y21vtjo8w9.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=2495@emacsbugs.donarmstrong.com \
    --cc=seltenreich@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).