bug#2388: 23.0.90; wrong-type-argument in vc-dir

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[robert]

If I run vc-dir in a svn controlled directory called 'Test Networks'
(with the internal space but not the quotes!), I get a wrong-type-argument
error, with the following traceback - 

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  vc-dir-node-directory(nil)

when I don't have debug-on-error set to t the *vc-dir* process never
completes.


In GNU Emacs 23.0.90.4 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-02-16 on robert-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  desktop-save-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[Dan Nicolaescu]

robert <robert.marshall@tnei.co.uk> writes:

  > If I run vc-dir in a svn controlled directory called 'Test Networks'
  > (with the internal space but not the quotes!), I get a wrong-type-argument
  > error, with the following traceback - 
  > 
  > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  >   ewoc-data(nil)
  >   vc-dir-node-directory(nil)
  > 
  > when I don't have debug-on-error set to t the *vc-dir* process never
  > completes.

I can't reproduce this.
Can you please post step by step recipe of how you get this, starting
with emacs -Q. 
The output of 
svn -u status
in that directory might be helpful too.

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[robert marshall]

Dan Nicolaescu wrote:
> robert <robert.marshall@tnei.co.uk> writes:
>
>   > If I run vc-dir in a svn controlled directory called 'Test Networks'
>   > (with the internal space but not the quotes!), I get a wrong-type-argument
>   > error, with the following traceback - 
>   > 
>   > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
>   >   ewoc-data(nil)
>   >   vc-dir-node-directory(nil)
>   > 
>   > when I don't have debug-on-error set to t the *vc-dir* process never
>   > completes.
>
> I can't reproduce this.
> Can you please post step by step recipe of how you get this, starting
> with emacs -Q. 
> The output of 
> svn -u status
> in that directory might be helpful too.
>   
I can't reproduce this either now :-(

I've done some checkins in that location and added a couple of files 
between when I reported the problem (which was very reproducible)
and now.
I will keep an eye on things and give a detailed recipe (and svn status) 
if it recurs.

Robert

-- 
Robert A J Marshall,  
TNEI Services Ltd, 86-90 London Road, Manchester, M1 2PW 
Registered in England & Wales No. 03891836,
Registered office:  Milburn House, Dean Street, Newcastle upon Tyne, NE1 1LE
tel: +44 161 615 6017; fax: +44 161 615 6001; mobile: +44 7759 688384 
web: http://IPSA-Power.com 

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[Nick Roberts]

robert marshall writes:
 > >   > If I run vc-dir in a svn controlled directory called 'Test Networks'
 > >   > (with the internal space but not the quotes!), I get a wrong-type-argument
 > >   > error, with the following traceback - 
 > >   > 
 > >   > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
 > >   >   ewoc-data(nil)
 > >   >   vc-dir-node-directory(nil)
 > >   > 
 > >   > when I don't have debug-on-error set to t the *vc-dir* process never
 > >   > completes.
 > >
 > > I can't reproduce this.
 > > Can you please post step by step recipe of how you get this, starting
 > > with emacs -Q. 
 > > The output of 
 > > svn -u status
 > > in that directory might be helpful too.
 > >   
 > I can't reproduce this either now :-(

I have seen this sometimes when files have needed merging/updating.  I don't
think it happened earlier because with SVN emacs didn't consult the remote
repository by default:

2009-01-30  Nick Roberts  <nickrob@snap.net.nz>

	* vc-svn.el (vc-svn-dir-status): Correct logic for remote
	connection.  (Bug#2093)

-- 
Nick                                           http://www.inet.net.nz/~nickrob

bug#2388: marked as done (23.0.90; wrong-type-argument in vc-dir)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]


Your message dated Tue, 24 Feb 2009 19:57:13 -0800 (PST)
with message-id <200902250357.n1P3vDjI000779@rodan.ics.uci.edu>
and subject line Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
has caused the Emacs bug report #2388,
regarding 23.0.90; wrong-type-argument in vc-dir
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2388: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2388
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3483 bytes --]

From: robert <robert.marshall@tnei.co.uk>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90; wrong-type-argument in vc-dir
Date: Thu, 19 Feb 2009 14:21:16 +0000
Message-ID: <87zlgi1p9f.fsf@tnei.co.uk>

If I run vc-dir in a svn controlled directory called 'Test Networks'
(with the internal space but not the quotes!), I get a wrong-type-argument
error, with the following traceback - 

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  vc-dir-node-directory(nil)

when I don't have debug-on-error set to t the *vc-dir* process never
completes.


In GNU Emacs 23.0.90.4 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-02-16 on robert-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  desktop-save-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t




[-- Attachment #3: Type: message/rfc822, Size: 2041 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: robert marshall <robert.marshall@tnei.co.uk>
Cc: 2388-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
Date: Tue, 24 Feb 2009 19:57:13 -0800 (PST)
Message-ID: <200902250357.n1P3vDjI000779@rodan.ics.uci.edu>

robert marshall <robert.marshall@tnei.co.uk> writes:

  > I can't reproduce this either now :-(

Then the bug is closed.

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[Nick Roberts]

Nick Roberts writes:
 >  > > I can't reproduce this.
 >  > > Can you please post step by step recipe of how you get this, starting
 >  > > with emacs -Q. 
 >  > > The output of 
 >  > > svn -u status
 >  > > in that directory might be helpful too.
 >  > >   
 >  > I can't reproduce this either now :-(
 > 
 > I have seen this sometimes when files have needed merging/updating.  I don't
 > think it happened earlier because with SVN emacs didn't consult the remote
 > repository by default:

I still see this.  Here's a recent backtrace:

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  (let ((data ...)) (or (vc-dir-fileinfo->directory data) 
(file-name-directory ...)))
  vc-dir-node-directory(nil)
  (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless (string-equal 
entrydir prev-dir) (ewoc-enter-before vc-ewoc node ...)))
  (cond ((string-lessp nodedir entrydir) (setq node ...)) ((string-equal 
nodedir entrydir) (let ... ...)) (t (let* ... ...) (ewoc-enter-before 
vc-ewoc node ...) (setq entries ... entry ...)))
  (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond (... ...) 
(... ...) (t ... ... ...)))
  (while (and entry node) (let* (... ... ...) (cond ... ... ...)))
  (let ((entry ...) (node ...) (dotname ...)) (unless node 
(ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry node) 
(let* ... ...)) (unless (or node noinsert) (let ... ...)))
  (save-current-buffer (set-buffer buffer) (setq entries (sort entries 
...)) (let (... ... ...) (unless node ... ...) (while ... ...) (unless 
... ...)))
  (with-current-buffer buffer (setq entries (sort entries ...)) (let 
(... ... ...) (unless node ... ...) (while ... ...) (unless ... ...)))
  vc-dir-update((("." needs-update) ("mydir" needs-update) 
("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) 
...

which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

bug#2566: 23.0.91; vc-dir: (wrong-type-argument arrayp nil)

[AE/Fischer Martin]

*** E-Mail body has been placed on clipboard, please paste them here!
***

--------------------------------------------------------------
Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  vc-dir-node-directory(nil)
  vc-dir-update((("jars\\vfst\\stala\\stala_src.jar" needs-update)
("test\\de\\vfst\\data\\transformer\\DatenuebernahmeTest.java"
needs-update) ("test\\de\\vfst\\epr\\converter\\testdata" needs-update)
("test\\de\\vfst\\epr\\converter\\base\\AbstractXmlTestBase.java"
needs-update) ("test\\de\\vfst\\epr\\converter\\base\\mssql.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\oracle.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\ortsbuch-derby_test.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\stamt.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\sybase-integration.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\sybase.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\test_external.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\EprActualFmTransformTest.ja
va" edited)
("test\\de\\vfst\\epr\\converter\\fachtests\\mssql.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\oracle.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\ortsbuch-derby_test.propert
ies" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\reg_from_ltChanges_aufl_tep
1_1_std_l_reg_vp_test1.xml" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\stamt.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\sybase-integration.properti
es" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\sybase.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\fachtests\\test.xml"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\test_external.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\testdata\\et"
needs-update) ("test\\de\\vfst\\epr\\converter\\testdata\\lt"
unregistered) ("test\\de\\vfst\\epr\\converter\\testdata\\{}"
unregistered)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\ehFromEpr_fm_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\fmEH_from_std_e_reg_all_
test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\fmEH_from_std_e_reg_all_
test2.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nanfe_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nanme_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nbe_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nbf_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nhf_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nhm_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_no_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nrfna_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emFromEpr_fm_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emToEpr_reg_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanfe
_all_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanfe
_all_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanme
_all_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanme
_all_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbe_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbe_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbf_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbf_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhf_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhf_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhm_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhm_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_no_1_
std_e_reg_aufl_b_test1.xml" needs-update) ...) #<buffer *vc-dir*>)
  #[(G31401 entries &optional more-to-come) "r\bJq  	\bJ\" \n? '
--------------------------------------------------------------


In GNU Emacs 23.0.91.1 (i386-mingw-nt5.1.2600)
 of 2009-02-27 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: DEU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <se
nd-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-cvs...done

bug#2566: 23.0.91; vc-dir: (wrong-type-argument arrayp nil)

[Dan Nicolaescu]

"AE/Fischer Martin" <aemf@vfst.de> writes:

  > *** E-Mail body has been placed on clipboard, please paste them here!
  > ***

Can you please provide a recipe on how reproduce this problem starting
from 
emacs -Q
?

Can you also provide the backtrace you get when doing:
emacs -Q
M-: (setq debug-on-error t) RET
M-x load-library vc-dir.el RET

then do whatever you do to cause this problem.

Thanks.

bug#2566: 23.0.91; vc-dir: (wrong-type-argument arrayp nil)

[Nick Roberts]

This is a duplicate of bug#2388.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[Dan Nicolaescu]

robert marshall <robert.marshall@tnei.co.uk> writes:

  > Nick Roberts wrote:
  > > Nick Roberts writes:
  > >  >  > > I can't reproduce this.
  > >  >  > > Can you please post step by step recipe of how you get this, starting
  > >  >  > > with emacs -Q.  >  > > The output of  >  > > svn -u status
  > >  >  > > in that directory might be helpful too.
  > >  >  > >    >  > I can't reproduce this either now :-(
  > >  >  > I have seen this sometimes when files have needed
  > > merging/updating.  I don't
  > >  > think it happened earlier because with SVN emacs didn't consult the remote
  > >  > repository by default:
  > >
  > > I still see this.  Here's a recent backtrace:
  > >
  > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  > >   ewoc-data(nil)
  > >   (let ((data ...)) (or (vc-dir-fileinfo->directory data)
  > > (file-name-directory ...)))
  > >   vc-dir-node-directory(nil)
  > >   (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless
  > > (string-equal entrydir prev-dir) (ewoc-enter-before vc-ewoc node
  > > ...)))
  > >   (cond ((string-lessp nodedir entrydir) (setq node ...))
  > > ((string-equal nodedir entrydir) (let ... ...)) (t (let* ... ...)
  > > (ewoc-enter-before vc-ewoc node ...) (setq entries ... entry ...)))
  > >   (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond
  > > (... ...) (... ...) (t ... ... ...)))
  > >   (while (and entry node) (let* (... ... ...) (cond ... ... ...)))
  > >   (let ((entry ...) (node ...) (dotname ...)) (unless node
  > > (ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry
  > > node) (let* ... ...)) (unless (or node noinsert) (let ... ...)))
  > >   (save-current-buffer (set-buffer buffer) (setq entries (sort
  > > entries ...)) (let (... ... ...) (unless node ... ...) (while
  > > ... ...) (unless ... ...)))
  > >   (with-current-buffer buffer (setq entries (sort entries ...)) (let
  > > (... ... ...) (unless node ... ...) (while ... ...) (unless
  > > ... ...)))
  > >   vc-dir-update((("." needs-update) ("mydir" needs-update)
  > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ...
  > >
  > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.
  > >
  > >   
  > I'm seeing this, today, the status gives me
  > 
  > svn -u status
  >       *     7243   tests/compare.py
  >       *     7243   tests/harm.py
  >       *     7243   tests/setup-win.py
  >       *     7243   ipsa.i
  >       *     7243   Makefile
  >       *     7243   IscNetComponent.cpp
  >       *     7243   IscNetComparator.h
  >       *     7243   IpsaComparator.cpp
  >       *     7243   IscNetComponent.h
  >       *     7243   IscNetComparator.cpp
  >       *            IscCompareData.h
  > ?                   ipsa_wrap.cpp
  > M      *     7243   IscInterface.cpp
  > ?                   ipsa.py
  >       *            IscCompareData.cpp
  >       *     7243   Scripting.vcproj
  >       *     7243   .
       ^^^^^^^^^^^^^^^^^^^^^^^^ 
   This might be the cause of the problem.  Can you please try thing
   patch:


Index: vc-svn.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v
retrieving revision 1.112
diff -u -3 -p -u -p -r1.112 vc-svn.el
--- vc-svn.el 10 Feb 2009 05:59:14 -0000        1.112
+++ vc-svn.el 10 Mar 2009 20:49:23 -0000
@@ -176,7 +176,7 @@ want to force an empty list of arguments
        ;; FIXME are there other possible combinations?
             (cond ((eq state 'edited) (setq state 'needs-merge))
                      ((not state) (setq state 'needs-update))))
-       (when state
+       (when (and state (not (string= "." filename)))
          (setq result (cons (list filename state) result)))))
     (funcall callback result)))

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[robert marshall]

Dan Nicolaescu wrote:
> robert marshall <robert.marshall@tnei.co.uk> writes:
>
>   > Nick Roberts wrote:
>   > > Nick Roberts writes:
>   > >  >  > > I can't reproduce this.
>   > >  >  > > Can you please post step by step recipe of how you get this, starting
>   > >  >  > > with emacs -Q.  >  > > The output of  >  > > svn -u status
>   > >  >  > > in that directory might be helpful too.
>   > >  >  > >    >  > I can't reproduce this either now :-(
>   > >  >  > I have seen this sometimes when files have needed
>   > > merging/updating.  I don't
>   > >  > think it happened earlier because with SVN emacs didn't consult the remote
>   > >  > repository by default:
>   > >
>   > > I still see this.  Here's a recent backtrace:
>   > >
>   > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
>   > >   ewoc-data(nil)
>   .. <snip>
>   > >   vc-dir-update((("." needs-update) ("mydir" needs-update)
>   > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ...
>   > >
>   > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.
>   > >
>   > >   
>   > I'm seeing this, today, the status gives me
>   > 
>   > svn -u status
>   >       *     7243   tests/compare.py
>   >       *     7243   tests/harm.py
>   >       *     7243   tests/setup-win.py
>   >       *     7243   ipsa.i
>   >       *     7243   Makefile
>   >       *     7243   IscNetComponent.cpp
>   >       *     7243   IscNetComparator.h
>   >       *     7243   IpsaComparator.cpp
>   >       *     7243   IscNetComponent.h
>   >       *     7243   IscNetComparator.cpp
>   >       *            IscCompareData.h
>   > ?                   ipsa_wrap.cpp
>   > M      *     7243   IscInterface.cpp
>   > ?                   ipsa.py
>   >       *            IscCompareData.cpp
>   >       *     7243   Scripting.vcproj
>   >       *     7243   .
>        ^^^^^^^^^^^^^^^^^^^^^^^^ 
>    This might be the cause of the problem.  Can you please try thing
>    patch:
>
>
> Index: vc-svn.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v
> retrieving revision 1.112
> diff -u -3 -p -u -p -r1.112 vc-svn.el
> --- vc-svn.el 10 Feb 2009 05:59:14 -0000        1.112
> +++ vc-svn.el 10 Mar 2009 20:49:23 -0000
> @@ -176,7 +176,7 @@ want to force an empty list of arguments
>         ;; FIXME are there other possible combinations?
>              (cond ((eq state 'edited) (setq state 'needs-merge))
>                       ((not state) (setq state 'needs-update))))
> -       (when state
> +       (when (and state (not (string= "." filename)))
>           (setq result (cons (list filename state) result)))))
>      (funcall callback result)))
>   
Thanks for this, I've installed it and will persuade my colleagues to do 
a few checkins :-)
Not sure why svn should list '.' as needing an update.  Unfortunately my 
svn is now
up to date so I can't, currently, replicate this issue.

Robert

-- 
Robert A J Marshall,  
TNEI Services Ltd, 86-90 London Road, Manchester, M1 2PW 
Registered in England & Wales No. 03891836,
Registered office:  Milburn House, Dean Street, Newcastle upon Tyne, NE1 1LE
tel: +44 161 615 6017; fax: +44 161 615 6001; mobile: +44 7759 688384 
web: http://IPSA-Power.com 

bug#2388: 23.0.90; wrong-type-argument in vc-dir

[Dan Nicolaescu]

robert marshall <robert.marshall@tnei.co.uk> writes:

  > Dan Nicolaescu wrote:
  > > robert marshall <robert.marshall@tnei.co.uk> writes:
  > >
  > >   > Nick Roberts wrote:
  > >   > > Nick Roberts writes:
  > >   > >  >  > > I can't reproduce this.
  > >   > >  >  > > Can you please post step by step recipe of how you get this, starting
  > >   > >  >  > > with emacs -Q.  >  > > The output of  >  > > svn -u status
  > >   > >  >  > > in that directory might be helpful too.
  > >   > >  >  > >    >  > I can't reproduce this either now :-(
  > >   > >  >  > I have seen this sometimes when files have needed
  > >   > > merging/updating.  I don't
  > >   > >  > think it happened earlier because with SVN emacs didn't consult the remote
  > >   > >  > repository by default:
  > >   > >
  > >   > > I still see this.  Here's a recent backtrace:
  > >   > >
  > >   > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  > >   > >   ewoc-data(nil)
  > >   .. <snip>
  > >   > >   vc-dir-update((("." needs-update) ("mydir" needs-update)
  > >   > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ...
  > >   > >
  > >   > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.
  > >   > >
  > >   > >     > I'm seeing this, today, the status gives me
  > >   >   > svn -u status
  > >   >       *     7243   tests/compare.py
  > >   >       *     7243   tests/harm.py
  > >   >       *     7243   tests/setup-win.py
  > >   >       *     7243   ipsa.i
  > >   >       *     7243   Makefile
  > >   >       *     7243   IscNetComponent.cpp
  > >   >       *     7243   IscNetComparator.h
  > >   >       *     7243   IpsaComparator.cpp
  > >   >       *     7243   IscNetComponent.h
  > >   >       *     7243   IscNetComparator.cpp
  > >   >       *            IscCompareData.h
  > >   > ?                   ipsa_wrap.cpp
  > >   > M      *     7243   IscInterface.cpp
  > >   > ?                   ipsa.py
  > >   >       *            IscCompareData.cpp
  > >   >       *     7243   Scripting.vcproj
  > >   >       *     7243   .
  > >        ^^^^^^^^^^^^^^^^^^^^^^^^    This might be the cause of the
  > > problem.  Can you please try thing
  > >    patch:
  > >
  > >
  > > Index: vc-svn.el
  > > ===================================================================
  > > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v
  > > retrieving revision 1.112
  > > diff -u -3 -p -u -p -r1.112 vc-svn.el
  > > --- vc-svn.el 10 Feb 2009 05:59:14 -0000        1.112
  > > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000
  > > @@ -176,7 +176,7 @@ want to force an empty list of arguments
  > >         ;; FIXME are there other possible combinations?
  > >              (cond ((eq state 'edited) (setq state 'needs-merge))
  > >                       ((not state) (setq state 'needs-update))))
  > > -       (when state
  > > +       (when (and state (not (string= "." filename)))
  > >           (setq result (cons (list filename state) result)))))
  > >      (funcall callback result)))
  > >   
  > Thanks for this, I've installed it and will persuade my colleagues to
  > do a few checkins :-)
  > Not sure why svn should list '.' as needing an update.  Unfortunately
  > my svn is now
  > up to date so I can't, currently, replicate this issue.

I would say it would be better to not install the above patch.  You can
install it whenever you hit the problem again and see if it help.
In case it doesn't saving the tree that generates the problem would help
testing a different fix.

bug#2566: marked as done (23.0.91; vc-dir: (wrong-type-argument arrayp nil))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]


Your message dated Tue, 14 Apr 2009 17:30:16 -0700 (PDT)
with message-id <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu>
and subject line Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
has caused the Emacs bug report #2388,
regarding 23.0.91; vc-dir: (wrong-type-argument arrayp nil)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2388: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2388
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 8545 bytes --]

From: "AE/Fischer Martin" <aemf@vfst.de>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.91; vc-dir: (wrong-type-argument arrayp nil)
Date: Wed, 4 Mar 2009 11:29:34 +0100
Message-ID: <70994F7DCC4F3549A6A7895E8D43B7B00B1864@dvxe.vfst.int>

*** E-Mail body has been placed on clipboard, please paste them here!
***

--------------------------------------------------------------
Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  vc-dir-node-directory(nil)
  vc-dir-update((("jars\\vfst\\stala\\stala_src.jar" needs-update)
("test\\de\\vfst\\data\\transformer\\DatenuebernahmeTest.java"
needs-update) ("test\\de\\vfst\\epr\\converter\\testdata" needs-update)
("test\\de\\vfst\\epr\\converter\\base\\AbstractXmlTestBase.java"
needs-update) ("test\\de\\vfst\\epr\\converter\\base\\mssql.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\oracle.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\ortsbuch-derby_test.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\stamt.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\sybase-integration.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\base\\sybase.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\base\\test_external.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\EprActualFmTransformTest.ja
va" edited)
("test\\de\\vfst\\epr\\converter\\fachtests\\mssql.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\oracle.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\ortsbuch-derby_test.propert
ies" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\reg_from_ltChanges_aufl_tep
1_1_std_l_reg_vp_test1.xml" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\stamt.properties"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\sybase-integration.properti
es" unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\sybase.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\fachtests\\test.xml"
unregistered)
("test\\de\\vfst\\epr\\converter\\fachtests\\test_external.properties"
unregistered) ("test\\de\\vfst\\epr\\converter\\testdata\\et"
needs-update) ("test\\de\\vfst\\epr\\converter\\testdata\\lt"
unregistered) ("test\\de\\vfst\\epr\\converter\\testdata\\{}"
unregistered)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\ehFromEpr_fm_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\fmEH_from_std_e_reg_all_
test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\eh\\fmEH_from_std_e_reg_all_
test2.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nanfe_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nanme_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nbe_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nbf_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nhf_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nhm_all_test1.
xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_no_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emChanges_nrfna_all_test
1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emFromEpr_fm_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\emToEpr_reg_test1.xml"
needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanfe
_all_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanfe
_all_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanme
_all_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nanme
_all_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbe_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbe_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbf_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nbf_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhf_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhf_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhm_a
ll_1_std_e_reg_aufl_b_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_nhm_a
ll_1_std_e_reg_vh_test1.xml" needs-update)
("test\\de\\vfst\\epr\\converter\\testdata\\em\\reg_from_emChanges_no_1_
std_e_reg_aufl_b_test1.xml" needs-update) ...) #<buffer *vc-dir*>)
  #[(G31401 entries &optional more-to-come) "r\bJq  	\bJ\" \n? '
--------------------------------------------------------------


In GNU Emacs 23.0.91.1 (i386-mingw-nt5.1.2600)
 of 2009-02-27 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: DEU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <se
nd-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-cvs...done



[-- Attachment #3: Type: message/rfc822, Size: 6451 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: 2388-done@emacsbugs.donarmstrong.com
Cc: robert marshall <robert.marshall@tnei.co.uk>
Subject: Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
Date: Tue, 14 Apr 2009 17:30:16 -0700 (PDT)
Message-ID: <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu>

Dan Nicolaescu <dann@ics.uci.edu> writes:

  > robert marshall <robert.marshall@tnei.co.uk> writes:
  > 
  >   > Nick Roberts wrote:
  >   > > Nick Roberts writes:
  >   > >  >  > > I can't reproduce this.
  >   > >  >  > > Can you please post step by step recipe of how you get this, starting
  >   > >  >  > > with emacs -Q.  >  > > The output of  >  > > svn -u status
  >   > >  >  > > in that directory might be helpful too.
  >   > >  >  > >    >  > I can't reproduce this either now :-(
  >   > >  >  > I have seen this sometimes when files have needed
  >   > > merging/updating.  I don't
  >   > >  > think it happened earlier because with SVN emacs didn't consult the remote
  >   > >  > repository by default:
  >   > >
  >   > > I still see this.  Here's a recent backtrace:
  >   > >
  >   > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  >   > >   ewoc-data(nil)
  >   > >   (let ((data ...)) (or (vc-dir-fileinfo->directory data)
  >   > > (file-name-directory ...)))
  >   > >   vc-dir-node-directory(nil)
  >   > >   (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless
  >   > > (string-equal entrydir prev-dir) (ewoc-enter-before vc-ewoc node
  >   > > ...)))
  >   > >   (cond ((string-lessp nodedir entrydir) (setq node ...))
  >   > > ((string-equal nodedir entrydir) (let ... ...)) (t (let* ... ...)
  >   > > (ewoc-enter-before vc-ewoc node ...) (setq entries ... entry ...)))
  >   > >   (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond
  >   > > (... ...) (... ...) (t ... ... ...)))
  >   > >   (while (and entry node) (let* (... ... ...) (cond ... ... ...)))
  >   > >   (let ((entry ...) (node ...) (dotname ...)) (unless node
  >   > > (ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry
  >   > > node) (let* ... ...)) (unless (or node noinsert) (let ... ...)))
  >   > >   (save-current-buffer (set-buffer buffer) (setq entries (sort
  >   > > entries ...)) (let (... ... ...) (unless node ... ...) (while
  >   > > ... ...) (unless ... ...)))
  >   > >   (with-current-buffer buffer (setq entries (sort entries ...)) (let
  >   > > (... ... ...) (unless node ... ...) (while ... ...) (unless
  >   > > ... ...)))
  >   > >   vc-dir-update((("." needs-update) ("mydir" needs-update)
  >   > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ...
  >   > >
  >   > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.
  >   > >
  >   > >   
  >   > I'm seeing this, today, the status gives me
  >   > 
  >   > svn -u status
  >   >       *     7243   tests/compare.py
  >   >       *     7243   tests/harm.py
  >   >       *     7243   tests/setup-win.py
  >   >       *     7243   ipsa.i
  >   >       *     7243   Makefile
  >   >       *     7243   IscNetComponent.cpp
  >   >       *     7243   IscNetComparator.h
  >   >       *     7243   IpsaComparator.cpp
  >   >       *     7243   IscNetComponent.h
  >   >       *     7243   IscNetComparator.cpp
  >   >       *            IscCompareData.h
  >   > ?                   ipsa_wrap.cpp
  >   > M      *     7243   IscInterface.cpp
  >   > ?                   ipsa.py
  >   >       *            IscCompareData.cpp
  >   >       *     7243   Scripting.vcproj
  >   >       *     7243   .
  >        ^^^^^^^^^^^^^^^^^^^^^^^^ 
  >    This might be the cause of the problem.  Can you please try thing
  >    patch:
  > 
  > 
  > Index: vc-svn.el
  > ===================================================================
  > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v
  > retrieving revision 1.112
  > diff -u -3 -p -u -p -r1.112 vc-svn.el
  > --- vc-svn.el 10 Feb 2009 05:59:14 -0000        1.112
  > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000
  > @@ -176,7 +176,7 @@ want to force an empty list of arguments
  >         ;; FIXME are there other possible combinations?
  >              (cond ((eq state 'edited) (setq state 'needs-merge))
  >                       ((not state) (setq state 'needs-update))))
  > -       (when state
  > +       (when (and state (not (string= "." filename)))
  >           (setq result (cons (list filename state) result)))))
  >      (funcall callback result)))

After doing "svn update -rSOME_OLDER_VERSION" it seems that "." can
appear in the "svn status" output.  So I applied this patch.

bug#2388: marked as done (23.0.90; wrong-type-argument in vc-dir)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Your message dated Tue, 14 Apr 2009 17:30:16 -0700 (PDT)
with message-id <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu>
and subject line Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
has caused the Emacs bug report #2388,
regarding 23.0.90; wrong-type-argument in vc-dir
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2388: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2388
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3483 bytes --]

From: robert <robert.marshall@tnei.co.uk>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90; wrong-type-argument in vc-dir
Date: Thu, 19 Feb 2009 14:21:16 +0000
Message-ID: <87zlgi1p9f.fsf@tnei.co.uk>

If I run vc-dir in a svn controlled directory called 'Test Networks'
(with the internal space but not the quotes!), I get a wrong-type-argument
error, with the following traceback - 

Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  ewoc-data(nil)
  vc-dir-node-directory(nil)

when I don't have debug-on-error set to t the *vc-dir* process never
completes.


In GNU Emacs 23.0.90.4 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-02-16 on robert-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  diff-auto-refine-mode: t
  desktop-save-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t




[-- Attachment #3: Type: message/rfc822, Size: 6451 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: 2388-done@emacsbugs.donarmstrong.com
Cc: robert marshall <robert.marshall@tnei.co.uk>
Subject: Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir
Date: Tue, 14 Apr 2009 17:30:16 -0700 (PDT)
Message-ID: <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu>

Dan Nicolaescu <dann@ics.uci.edu> writes:

  > robert marshall <robert.marshall@tnei.co.uk> writes:
  > 
  >   > Nick Roberts wrote:
  >   > > Nick Roberts writes:
  >   > >  >  > > I can't reproduce this.
  >   > >  >  > > Can you please post step by step recipe of how you get this, starting
  >   > >  >  > > with emacs -Q.  >  > > The output of  >  > > svn -u status
  >   > >  >  > > in that directory might be helpful too.
  >   > >  >  > >    >  > I can't reproduce this either now :-(
  >   > >  >  > I have seen this sometimes when files have needed
  >   > > merging/updating.  I don't
  >   > >  > think it happened earlier because with SVN emacs didn't consult the remote
  >   > >  > repository by default:
  >   > >
  >   > > I still see this.  Here's a recent backtrace:
  >   > >
  >   > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
  >   > >   ewoc-data(nil)
  >   > >   (let ((data ...)) (or (vc-dir-fileinfo->directory data)
  >   > > (file-name-directory ...)))
  >   > >   vc-dir-node-directory(nil)
  >   > >   (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless
  >   > > (string-equal entrydir prev-dir) (ewoc-enter-before vc-ewoc node
  >   > > ...)))
  >   > >   (cond ((string-lessp nodedir entrydir) (setq node ...))
  >   > > ((string-equal nodedir entrydir) (let ... ...)) (t (let* ... ...)
  >   > > (ewoc-enter-before vc-ewoc node ...) (setq entries ... entry ...)))
  >   > >   (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond
  >   > > (... ...) (... ...) (t ... ... ...)))
  >   > >   (while (and entry node) (let* (... ... ...) (cond ... ... ...)))
  >   > >   (let ((entry ...) (node ...) (dotname ...)) (unless node
  >   > > (ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry
  >   > > node) (let* ... ...)) (unless (or node noinsert) (let ... ...)))
  >   > >   (save-current-buffer (set-buffer buffer) (setq entries (sort
  >   > > entries ...)) (let (... ... ...) (unless node ... ...) (while
  >   > > ... ...) (unless ... ...)))
  >   > >   (with-current-buffer buffer (setq entries (sort entries ...)) (let
  >   > > (... ... ...) (unless node ... ...) (while ... ...) (unless
  >   > > ... ...)))
  >   > >   vc-dir-update((("." needs-update) ("mydir" needs-update)
  >   > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ...
  >   > >
  >   > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil.
  >   > >
  >   > >   
  >   > I'm seeing this, today, the status gives me
  >   > 
  >   > svn -u status
  >   >       *     7243   tests/compare.py
  >   >       *     7243   tests/harm.py
  >   >       *     7243   tests/setup-win.py
  >   >       *     7243   ipsa.i
  >   >       *     7243   Makefile
  >   >       *     7243   IscNetComponent.cpp
  >   >       *     7243   IscNetComparator.h
  >   >       *     7243   IpsaComparator.cpp
  >   >       *     7243   IscNetComponent.h
  >   >       *     7243   IscNetComparator.cpp
  >   >       *            IscCompareData.h
  >   > ?                   ipsa_wrap.cpp
  >   > M      *     7243   IscInterface.cpp
  >   > ?                   ipsa.py
  >   >       *            IscCompareData.cpp
  >   >       *     7243   Scripting.vcproj
  >   >       *     7243   .
  >        ^^^^^^^^^^^^^^^^^^^^^^^^ 
  >    This might be the cause of the problem.  Can you please try thing
  >    patch:
  > 
  > 
  > Index: vc-svn.el
  > ===================================================================
  > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v
  > retrieving revision 1.112
  > diff -u -3 -p -u -p -r1.112 vc-svn.el
  > --- vc-svn.el 10 Feb 2009 05:59:14 -0000        1.112
  > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000
  > @@ -176,7 +176,7 @@ want to force an empty list of arguments
  >         ;; FIXME are there other possible combinations?
  >              (cond ((eq state 'edited) (setq state 'needs-merge))
  >                       ((not state) (setq state 'needs-update))))
  > -       (when state
  > +       (when (and state (not (string= "." filename)))
  >           (setq result (cons (list filename state) result)))))
  >      (funcall callback result)))

After doing "svn update -rSOME_OLDER_VERSION" it seems that "." can
appear in the "svn status" output.  So I applied this patch.